Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(zigbee): Add connected(), minor fixes, example update #10636

Merged
merged 8 commits into from
Nov 25, 2024

Conversation

P-R-O-C-H-Y
Copy link
Member

Description of Change

This PR adds Zigbee.conneted() function and the Zigbee.begin() is now blocking until the Zigbee is started.
Some minor API changes + example updates.

Tests scenarios

Related links

@P-R-O-C-H-Y P-R-O-C-H-Y self-assigned this Nov 22, 2024
Copy link
Contributor

github-actions bot commented Nov 22, 2024

Warnings
⚠️ Please consider squashing your 8 commits (simplifying branch history).
⚠️
	The **target branch** for this Pull Request **must be the default branch** of the project (`master`).

	If you would like to add this feature to a different branch, please state this in the PR description and we will consider it.

👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against f5ac1a7

Copy link
Contributor

github-actions bot commented Nov 22, 2024

Test Results

 61 files   61 suites   5m 48s ⏱️
 21 tests  21 ✅ 0 💤 0 ❌
143 runs  143 ✅ 0 💤 0 ❌

Results for commit f5ac1a7.

♻️ This comment has been updated with latest results.

Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32C60‼️ +17K0.00‼️ +3.230⚠️ +16960.00‼️ +5.71
ESP32H20‼️ +14K0.00‼️ +2.490⚠️ +15960.00‼️ +5.50
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32C6ESP32H2
ExampleFLASHRAMFLASHRAM
Zigbee/examples/Zigbee_Color_Dimmable_Light‼️ +17K⚠️ +1680‼️ +14K⚠️ +1580
Zigbee/examples/Zigbee_Color_Dimmer_Switch‼️ +9K⚠️ +936‼️ +6K⚠️ +860
Zigbee/examples/Zigbee_On_Off_Light‼️ +16K⚠️ +1696‼️ +13K⚠️ +1596
Zigbee/examples/Zigbee_On_Off_Switch‼️ +10K⚠️ +920‼️ +6K⚠️ +860
Zigbee/examples/Zigbee_Scan_Networks‼️ +13K⚠️ +1260‼️ +9K⚠️ +1128
Zigbee/examples/Zigbee_Temp_Hum_Sensor_Sleepy‼️ +14K⚠️ +972‼️ +11K⚠️ +832
Zigbee/examples/Zigbee_Temperature_Sensor‼️ +11K⚠️ +944‼️ +8K⚠️ +836
Zigbee/examples/Zigbee_Thermostat‼️ +11K⚠️ +608‼️ +8K⚠️ +540

@P-R-O-C-H-Y P-R-O-C-H-Y added the Area: Libraries Issue is related to Library support. label Nov 22, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Review needed Issue or PR is awaiting review label Nov 22, 2024
@P-R-O-C-H-Y P-R-O-C-H-Y added this to the 3.1.0 milestone Nov 22, 2024
Copy link
Collaborator

@SuGlider SuGlider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @P-R-O-C-H-Y - Please take a look to the suggested changes.

Windows requires '\r' + '\n' at the end of a line in order to make it work with most Serial Termnals, such as PuTTY and others.

Adding '\r' doesn't affect Linux or MacOS, but is important to Windows.

Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
@me-no-dev me-no-dev added Status: Pending Merge Pull Request is ready to be merged and removed Status: Review needed Issue or PR is awaiting review labels Nov 25, 2024
@me-no-dev me-no-dev merged commit 1730e4e into espressif:release/v3.1.x Nov 25, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Libraries Issue is related to Library support. Status: Pending Merge Pull Request is ready to be merged
Projects
Development

Successfully merging this pull request may close these issues.

4 participants