-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(zigbee): Add connected(), minor fixes, example update #10636
fix(zigbee): Add connected(), minor fixes, example update #10636
Conversation
👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 61 files 61 suites 5m 48s ⏱️ Results for commit f5ac1a7. ♻️ This comment has been updated with latest results. |
Memory usage test (comparing PR against master branch)The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.
Click to expand the detailed deltas report [usage change in BYTES]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. @P-R-O-C-H-Y - Please take a look to the suggested changes.
Windows requires '\r' + '\n' at the end of a line in order to make it work with most Serial Termnals, such as PuTTY and others.
Adding '\r' doesn't affect Linux or MacOS, but is important to Windows.
libraries/Zigbee/examples/Zigbee_Temp_Hum_Sensor_Sleepy/Zigbee_Temp_Hum_Sensor_Sleepy.ino
Outdated
Show resolved
Hide resolved
libraries/Zigbee/examples/Zigbee_Temperature_Sensor/Zigbee_Temperature_Sensor.ino
Outdated
Show resolved
Hide resolved
Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
Description of Change
This PR adds Zigbee.conneted() function and the Zigbee.begin() is now blocking until the Zigbee is started.
Some minor API changes + example updates.
Tests scenarios
Related links