Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat (Variants) Added custom boards variants GLYPH C3, GLYPHC6 & GLYPHH2 #10671

Merged
merged 7 commits into from
Dec 9, 2024

Conversation

pcbcupid
Copy link
Contributor

@pcbcupid pcbcupid commented Dec 3, 2024

Added custom boards variants GLYPH C3, GLYPHC6 & GLYPHH2 based on ESP32C3, ESP32C6 & ESP32H2

Description of Change

This Pull Request add support to our three new hardware GLYPHC3 , GLYPHC6 and GLYPHH2 which are based on ESP32C3, ESP32C6 and ESP32H2. Features onboard LiPo/Li-ion charging circuit, QWIIC connector for QWIIC compatible sensors/modules and "Adafruit Feather Series" style footprint.

Links to the product :

Tests scenarios

The hardware's are tested with these changes on a GLYPH boards using the Arduino IDE with ESP32 core. Also verified that the defined pins correspond to the correct hardware pins on the board.

Related links

These links contain the information & documentation related to GLYPH boards :

@CLAassistant
Copy link

CLAassistant commented Dec 3, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Added custom boards GLYPH C3, GLYPHC6 & GLYPHH2 based on ESP32C3, ESP32C6 & ESP32H2":
    • summary looks empty
    • type/action looks empty
  • the commit message "added required fix : moved the variants to end and fixed build.board":
    • summary looks empty
    • type/action looks empty
  • the commit message "feat(Variants) : Added custom boards GLYPH C3, GLYPHC6 & GLYPHH2":
    • body's lines must not be longer than 100 characters
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️ Please consider squashing your 7 commits (simplifying branch history).

👋 Hello pcbcupid, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 4240caa

Added custom boards variants from PCBCUPID - GLYPH C3, GLYPHC6 & GLYPHH2 based on ESP32C3, ESP32C6 & ESP32H2
@P-R-O-C-H-Y
Copy link
Member

Hello @pcbcupid, can you please fix the errors from the CI. The build.board must be uppercase.
Also as those are your first boards in the repository, please add them to the end of the boards.txt file. Thanks

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Awaiting Response awaiting a response from the author label Dec 3, 2024
@pcbcupid pcbcupid changed the title Added custom boards variants GLYPH C3, GLYPHC6 & GLYPHH2 based on ESP32C3, ESP32C6 & ESP32H2 feat (Variants) Added custom boards variants GLYPH C3, GLYPHC6 & GLYPHH2 Dec 3, 2024
@P-R-O-C-H-Y
Copy link
Member

@pcbcupid Also please sign the CLA. Without that the PR cannot be merged.

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending CLA ⚠️ Contributor is required to sign the CLA and removed Status: Awaiting Response awaiting a response from the author labels Dec 3, 2024
@pcbcupid
Copy link
Contributor Author

pcbcupid commented Dec 3, 2024

image

@P-R-O-C-H-Y Tried signing the CLA and "Recheck", but as you can see in the above image the page is frozen indefinitely.

@me-no-dev
Copy link
Member

@pcbcupid please try again in a bit. There seems to have been an issue with the CLA service.

@pcbcupid
Copy link
Contributor Author

pcbcupid commented Dec 4, 2024

image

@P-R-O-C-H-Y Seems like the license/cla is not updating or reflecting on this pull request.

@P-R-O-C-H-Y
Copy link
Member

@pcbcupid Seems its ok now :)

@P-R-O-C-H-Y P-R-O-C-H-Y added Status: Pending Merge Pull Request is ready to be merged and removed Status: Pending CLA ⚠️ Contributor is required to sign the CLA labels Dec 4, 2024
@pcbcupid
Copy link
Contributor Author

pcbcupid commented Dec 4, 2024

@P-R-O-C-H-Y Yes! Thanks.

@me-no-dev me-no-dev merged commit 77c69c3 into espressif:master Dec 9, 2024
11 checks passed
Jason2866 added a commit to tasmota/arduino-esp32 that referenced this pull request Dec 11, 2024
* fix(zigbee): Increase timeout, commision again on failure + setScanDuration (espressif#10651)

* fix(zigbee): Increase timeout, commision again on failure
* fix(zigbee): Update library keywords

* feat(Matter): add new MatterColorLight endpoint (espressif#10654)

* feat(matter): adds Matter Color Light endpoint

* feat(matter): New example => Wifi Prov within Matter as alternative for wireless network provisioning (espressif#10658)

* feat(matter): Arduino WiFi Prov example for Matter

* feat(matter): Adds Matter Enhanced Color Light Endpoint (CW/WW/RGB) (espressif#10657)

* feat(matter): created enhanced color light new matter endpoint and example

* feat(matter): Adds a new Matter Endpoint: Generic Switch (smart button) (espressif#10662)

* feat(matter): adds new matter generic switch endpoint

* fix(matter): no need of arduino preferences here

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* BLECharacteristic optimization (espressif#10665)

* BLECharacteristic::notify() optimization

GeneralUtils::hexDump() doesn't output anything if the log level is not "VERBOSE". Additionally, it is very CPU intensive, even when it doesn't output anything. So it is much better to *not* call it at all if not needed. 

In a simple program which calls BLECharacteristic::notify() every 50 ms, the performance gain of this little optimization is 37% in release mode (-O3) and 57% in debug mode. 

Of course, the "#if ARDUHAL_LOG_LEVEL >= ARDUHAL_LOG_LEVEL_VERBOSE" guard could also be put inside the GeneralUtils::hexDump() function itself. But it's better to put it here also, as it is clearer (indicating a verbose log thing) and it allows to remove the "m_value.getValue().c_str()" call, which is in itself quite CPU intensive.

* BLECharacteristic optimization

Calls to BLEUtils::buildHexData() don't output anything when the log level is not "VERBOSE" or "DEBUG". As this function is quite CPU intensive, it is better to not call it when not needed.

* Remove 3rd party references in code and documentation (espressif#10666)

* feat(support): documentation adjustment
* feat(support): readme files, commentaries and examples
* fix(template): Fix Issue Report Template
-----------------------------
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>

* Tasmota changes

* optional Ethernet support (JL1101 driver added)
* esp-modem only esp32, esp32s2 and esp32s3
* remove `OpenThread`
* remove all BT BLE libraries
* remove zigbee
* remove SPIFFS
* remove Client Secure
* remove Provisioning
* remove TfLite, Insights and Rainmaker
* make GPIOViewer working see arendst/Tasmota@9696118
* remove FS log which is just littering

* refactor(uart): Refactor UART test to work with any number of UARTs (espressif#10593)

* refactor(uart): Refactor UART test to work with any number of UARTs

Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>

* fix(uart): Set CPU freq on ESP32

* ci(pre-commit): Apply automatic fixes

* fix(spelling): Fix codespell error

---------

Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* feat (Variants) Added custom boards variants GLYPH C3, GLYPHC6 & GLYPHH2 (espressif#10671)

* Added custom boards GLYPH C3, GLYPHC6 & GLYPHH2 based on ESP32C3, ESP32C6 & ESP32H2

* feat(Variants) : Added custom boards GLYPH C3, GLYPHC6 & GLYPHH2

Added custom boards variants from PCBCUPID - GLYPH C3, GLYPHC6 & GLYPHH2 based on ESP32C3, ESP32C6 & ESP32H2

* added required fix : moved the variants to end and fixed build.board

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: srini <srinivasanm329@gmail.com>
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* feat(Zigbee): Recall bounded devices after reboot + IEEE address option for commands (espressif#10676)

* feat(zigbee): Recall bound devices after reboot

* fix(zigbee): Add missing locks + allow printBoundDevices to Serial

* fix(Zigbee): Add locks to temp sensor setReporting

* fix(Zigbee): remove unnecessary space in formatting

* fix(Zigbee): proper parameter in printBoundDevices

* feat(Zigbee): factory reset when removed from network

* fix(zigbee): Update comment

* fix(zigbee): fix serial and add missing factoryReset to example

* ci(pre-commit): Apply automatic fixes

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* ci(pre-commit): Bump hooks versions and fix leftover files (espressif#10680)

* update(hooks): Bump pre-commit hooks versions

* fix(formatting): Fix python script formatting

* fix(formatting): Fix leftover files on protected folders

* feat(Matter): Creates New Matter Fan Controller Endpoint (espressif#10691)

* feat(matter): creates new matter fan controller endpoint

* change(tools): Push generated binaries to PR

* ci(pre-commit): Add bash script formatter and linter (espressif#10681)

* ci(pre-commit): Add check for bash scripts

* fix(formatting): Fix bash scripts

* docs(pre-commit): Add info about the included hooks

* fix ESP32-U4WDH chip detection by ESP.getChipModel() (espressif#10696)

* fixes chip detection for ESP32-U4WDH

* fix(push): Re-comment unused code

* feat(matter): adds new Temperature Sensor Matter Endpoint (espressif#10698)

* feat(matter): adds new temperature sensor matter endpoint

* feat(matter): commentaries review and fixes

* feat(matter): commentaries review and fixes

* feat(matter): commentaries review and fixes

* feat(matter): commentaries review and fixes

* feat(matter): commentaries review and fixes

* feat(matter): commentaries review and fixes

* feat(matter): general commentaries and code review

* feat(matter): keeping arduino style for local variables (lower case)

* feat(matter): applies a generic temperature unit to the implementation and example

* fix(matter): fixed problem with begin(float) implementation

* fix(matter): fixed begin(float) initiallization

* feat(matter): updated matter temperature keywords with new api

* ci(pre-commit): Apply automatic fixes

* fix(matter): fixed code spell ci errors in matter temperature sensor

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>

* feat(chip): Add definition for BOOT_PIN for all chips (espressif#10700)

* feat(chip): Add definition for BOOT_PIN for all chips

For use in sketches as default button

* fix(core): Make BOOT_PIN static

* fix(hal): BOOT_PIN should always be defined

* feat(Matter): Adds New Matter Humidity Sensor Endpoint (espressif#10703)

* feat(matter): adds matter humidity sensor endpoint

* Update and rename platformio-build.py to pioarduino-build.py

* feat(matter_examples): apply boot button change to all examples (espressif#10702)

* feat(matter_examples): apply boot button change to all examples

* ci(tests): Re-enable UART test for P4

* Delete libraries/Matter directory

---------

Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
Co-authored-by: Jan Procházka <90197375+P-R-O-C-H-Y@users.noreply.github.com>
Co-authored-by: Me No Dev <me-no-dev@users.noreply.github.com>
Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: Sylvain Quendez <sylvain.quendez@gmail.com>
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
Co-authored-by: PCB CUPID <123002577+pcbcupid@users.noreply.github.com>
Co-authored-by: srini <srinivasanm329@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Michael Stegen <mstegen@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants