-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(board): Add custom boards YB-ESP32-S3-AMP-V2 & YB-ESP32-S3-AMP-V3 #10699
Conversation
👋 Hello yellobyte, we appreciate your contribution to this project! Click to see more instructions ...
Review and merge process you can expect ...
|
mixed line endings fixed, pre-commit succssful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remark: A pre-commit check on the just updated board.txt showed no issues:
PS D:\Projects\Github\arduino-esp32> pre-commit run --files boards.txt
check for case conflicts.................................................Passed
check for broken symlinks............................(no files to check)Skipped
debug statements (python)............................(no files to check)Skipped
detect destroyed symlinks................................................Passed
detect private key.......................................................Passed
fix end of files.........................................................Passed
mixed line ending........................................................Passed
trim trailing whitespace.................................................Passed
codespell................................................................Passed
clang-format.........................................(no files to check)Skipped
black................................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
prettier.............................................(no files to check)Skipped
vale-sync............................................(no files to check)Skipped
vale.................................................(no files to check)Skipped
PS D:\Projects\Github\arduino-esp32>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, be sure to remove all FLASH and PARTITION options, that does not fit the actual board flash size :)
Thing is I sell/produce those boards with different ESP32-S3-WROOM-1 modules soldered on: |
If you sell boards with all those variants of flash its great to have them. I was just pointing that if you are selling lets say only 4,8 MB variants to remove the 16MB option. But its not the case. PR will be merged soon :) |
Thanks for your kind support and for pointing it out. I fully understand your concerns and appreciate any helpful comment. |
Description of Change
New boards YB-ESP32-S3-AMP-V2 and YB-ESP32-S3-AMP-V3 added to board list.
Tests scenarios
Builds successfully tested with both boards on actual Arduino-esp32 core revision.
Related links
Closes: #10656
Board info: https://github.com/yellobyte/ESP32-DevBoards-Getting-Started/tree/main/boards/YB-ESP32-S3-AMP