Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(board): Add custom boards YB-ESP32-S3-AMP-V2 & YB-ESP32-S3-AMP-V3 #10699

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

yellobyte
Copy link
Contributor

Description of Change

New boards YB-ESP32-S3-AMP-V2 and YB-ESP32-S3-AMP-V3 added to board list.

Tests scenarios

Builds successfully tested with both boards on actual Arduino-esp32 core revision.

Related links

Closes: #10656
Board info: https://github.com/yellobyte/ESP32-DevBoards-Getting-Started/tree/main/boards/YB-ESP32-S3-AMP

Copy link
Contributor

github-actions bot commented Dec 9, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Update boards.txt":
    • summary looks empty
    • type/action looks empty
  • the commit message "add custom boards yb_esp32s3_amp v2 & v3":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

Messages
📖 You might consider squashing your 3 commits (simplifying branch history).

👋 Hello yellobyte, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 9c169fa

mixed line endings fixed, pre-commit succssful
Copy link
Contributor Author

@yellobyte yellobyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remark: A pre-commit check on the just updated board.txt showed no issues:

PS D:\Projects\Github\arduino-esp32> pre-commit run --files boards.txt
check for case conflicts.................................................Passed
check for broken symlinks............................(no files to check)Skipped
debug statements (python)............................(no files to check)Skipped
detect destroyed symlinks................................................Passed
detect private key.......................................................Passed
fix end of files.........................................................Passed
mixed line ending........................................................Passed
trim trailing whitespace.................................................Passed
codespell................................................................Passed
clang-format.........................................(no files to check)Skipped
black................................................(no files to check)Skipped
flake8...............................................(no files to check)Skipped
prettier.............................................(no files to check)Skipped
vale-sync............................................(no files to check)Skipped
vale.................................................(no files to check)Skipped
PS D:\Projects\Github\arduino-esp32>

Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, be sure to remove all FLASH and PARTITION options, that does not fit the actual board flash size :)

@yellobyte
Copy link
Contributor Author

Thing is I sell/produce those boards with different ESP32-S3-WROOM-1 modules soldered on:
-N8R2 is in high demand, the odd customers want -N4 only, resp. -N16R8
That's why I kept different options. That's wrong ??

@P-R-O-C-H-Y
Copy link
Member

Thing is I sell/produce those boards with different ESP32-S3-WROOM-1 modules soldered on:

-N8R2 is in high demand, the odd customers want -N4 only, resp. -N16R8

That's why I kept different options. That's wrong ??

If you sell boards with all those variants of flash its great to have them. I was just pointing that if you are selling lets say only 4,8 MB variants to remove the 16MB option. But its not the case. PR will be merged soon :)

@P-R-O-C-H-Y P-R-O-C-H-Y added the Status: Pending Merge Pull Request is ready to be merged label Dec 10, 2024
@yellobyte
Copy link
Contributor Author

yellobyte commented Dec 10, 2024

Thanks for your kind support and for pointing it out. I fully understand your concerns and appreciate any helpful comment.
I will make a pull request for one of my other boards in some time. Regards

@me-no-dev me-no-dev merged commit 237523e into espressif:master Dec 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Pending Merge Pull Request is ready to be merged Type: 3rd party Boards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please add board YB-ESP32-S3-AMP to your boardlist
4 participants