Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(3rd-party): Add section for third party tools #10748

Closed
wants to merge 2 commits into from
Closed

docs(3rd-party): Add section for third party tools #10748

wants to merge 2 commits into from

Conversation

lucasssvaz
Copy link
Collaborator

Description of Change

Add section for 3rd party tools in the documentation. Also fixes issues with dependencies in Python 3.13

Tests scenarios

Locally

Related links

#10045

@lucasssvaz lucasssvaz self-assigned this Dec 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

Warnings
⚠️ 
	The **target branch** for this Pull Request **must be the default branch** of the project (`master`).

	If you would like to add this feature to a different branch, please state this in the PR description and we will consider it.

👋 Hello lucasssvaz, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 8a78481

@lucasssvaz lucasssvaz marked this pull request as ready for review December 18, 2024 13:03
@lucasssvaz lucasssvaz added the Type: Documentation Issue pertains to Documentation of Arduino ESP32 label Dec 18, 2024
P-R-O-C-H-Y
P-R-O-C-H-Y approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small typo, idk if pre-commit will fix automatically

docs/en/thirdparty/wokwi.rst

Wokwi is an online Electronics simulator. You can use it to simulate Arduino, ESP32, and many other popular boards, parts and sensors.

The advantages of using Wokwi inlcude:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The advantages of using Wokwi inlcude:
The advantages of using Wokwi include:

@me-no-dev me-no-dev deleted the branch espressif:release/v3.1.x December 18, 2024 13:56
@me-no-dev me-no-dev closed this Dec 18, 2024
@Jason2866
Copy link
Collaborator

@me-no-dev Probably accidentally closed by deleting the merged branch

@lucasssvaz
Copy link
Collaborator Author

@Jason2866 The new PR is here #10749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P-R-O-C-H-Y P-R-O-C-H-Y P-R-O-C-H-Y approved these changes

Assignees

@lucasssvaz lucasssvaz

Labels
Type: Documentation Issue pertains to Documentation of Arduino ESP32
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lucasssvaz @Jason2866 @P-R-O-C-H-Y @me-no-dev