Add #ifndef for USB_VID and USB_PID for esp32s3 board variant #10815
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This adds
#ifndef
s for theUSB_VID
andUSB_PID
#define
s for theesp32s3
board variant. By adding#ifndef
s, this allows the end user to customize the Vendor ID and Product ID that the device shows up as.Tangentially: Should this be added to other variants? To all variants? Some of the variants also define
USB_MANUFACTURER
,USB_PRODUCT
and/orUSB_SERIAL
with no way to override them. Should those also get#ifndef
s?Tests scenarios
I tested this with an ESP32-S3 (supermini) by including/excluding different combinations of
-DUSB_VID=0x1234
and-DUSB_PID=0x5678
build flags