Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added methods to remove service UUID from BLEAdvertising #8747

Conversation

dpnebert
Copy link
Contributor

@dpnebert dpnebert commented Oct 9, 2023

Added three methods for removing service UUID from BLEAdvertising

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Please update relevant Documentation if applicable
  4. Please check Contributing guide

This entire section above can be deleted if all items are checked.


Description of Change

Added methods for removing service UUIDs from 'BLEAdvertising'.

Tests scenarios

I have not had any time at work to compile and test.

Related links

None.

Added three methods for removing service UUID from BLEAdvertised
@dpnebert dpnebert changed the title Modified 'BLEAdvertising.h' & 'BLEAdvertising.cpp' Added methods to remove service UUID from BLEAdvertising Oct 9, 2023
@VojtechBartoska VojtechBartoska added the Status: Review needed Issue or PR is awaiting review label Nov 28, 2023
@VojtechBartoska VojtechBartoska added this to the 3.0.0-Aplha3 milestone Nov 28, 2023
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@me-no-dev me-no-dev merged commit c1417e9 into espressif:master Nov 29, 2023
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Review needed Issue or PR is awaiting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants