Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sizes delta report test #9520

Closed
wants to merge 73 commits into from
Closed

Sizes delta report test #9520

wants to merge 73 commits into from

Conversation

P-R-O-C-H-Y
Copy link
Member

@P-R-O-C-H-Y P-R-O-C-H-Y commented Apr 16, 2024 •
edited
Loading

Testing PR for Sizes delta report

P-R-O-C-H-Y added 30 commits March 1, 2024 13:29
@P-R-O-C-H-Y
feat(eth): Support phy address auto detection
49f7862
@P-R-O-C-H-Y
fix(eth): add phy_address check
c6ecba0
@P-R-O-C-H-Y
Create sizes.yml
a2067f5
@P-R-O-C-H-Y
Update sizes.yml
c191d8b
@P-R-O-C-H-Y
Create sizes.yml
9d85f27
@P-R-O-C-H-Y
Merge branch 'master' into fix/ethernet
93a71ba
@P-R-O-C-H-Y
Update sizes.yml
ccd5202
@P-R-O-C-H-Y
Update sizes.yml
9382bdb
@P-R-O-C-H-Y
Update sizes.yml
936cad0
@P-R-O-C-H-Y
Update sizes.yml
ab29736
@P-R-O-C-H-Y
Update sizes.yml
25e31f2
@P-R-O-C-H-Y
Update sizes.yml
a3a8c96
@P-R-O-C-H-Y
update workflows
ea3baac
@P-R-O-C-H-Y
update bash
474eb21
@P-R-O-C-H-Y
Update publishlib.yml
e706068
@P-R-O-C-H-Y
Merge branch 'master' into fix/ethernet
747aa09
@P-R-O-C-H-Y
update bash
3241f13
@P-R-O-C-H-Y
update bash
8fef6ed
@P-R-O-C-H-Y
Update publishlib.yml
9a06727
@P-R-O-C-H-Y
Update publishlib.yml
430f2e3
@P-R-O-C-H-Y
Update publishlib.yml
c958919
@P-R-O-C-H-Y
Update publishlib.yml
d5307b9
@P-R-O-C-H-Y
Merge branch 'master' into fix/ethernet
28ed7e3
@P-R-O-C-H-Y
Update publishlib.yml
1b1c578
@P-R-O-C-H-Y
Update publishlib.yml
930c554
@P-R-O-C-H-Y
Update publishlib.yml
77eb3ba
@P-R-O-C-H-Y
Update publishsizes.yml
38ee3e7
@P-R-O-C-H-Y
Compile all examples
a5ff9ca
@P-R-O-C-H-Y
Add Huge_app partition to fqbn
c90fb0a
@P-R-O-C-H-Y
save sizes in push workflow
312ecf7
@P-R-O-C-H-Y P-R-O-C-H-Y changed the title debug test Sizes delta report test Apr 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 16, 2024 •
edited
Loading

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "2nd build run":
    • summary looks empty
    • type/action looks empty
  • the commit message "Add Huge_app partition to fqbn":
    • summary looks empty
    • type/action looks empty
  • the commit message "Change name to HWCDC_Events.ino (From HWSerial_Events.ino) (#9483)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Compile all examples":
    • summary looks empty
    • type/action looks empty
  • the commit message "Create sizes.yml":
    • summary looks empty
    • type/action looks empty
  • the commit message "Create sizes.yml":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix typo in Updater.cpp (#9511)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Handle large octet-stream (master branch) (#9440)":
    • summary looks empty
    • type/action looks empty
  • the commit message "IDF release/v5.1 (#9498)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Refactor repository with pre-commit hooks (#9515)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Sort artifacts to pr or master folder":
    • summary looks empty
    • type/action looks empty
  • the commit message "Style Checker and Pre-commit hook CI (#9132)":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update json file location":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update on-push.sh":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update on-push.sh":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update on-push.sh":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update publishlib.yml":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update publishlib.yml":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update publishlib.yml":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update publishlib.yml":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update publishlib.yml":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update publishlib.yml":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update publishlib.yml":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update publishlib.yml":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update publishsizes.yml":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update publishsizes.yml":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update publishsizes.yml":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update push.yml":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update sizes.yml":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update sizes.yml":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update sizes.yml":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update sizes.yml":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update sizes.yml":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update sizes.yml":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update sizes.yml":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update sketch_utils.sh":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update sketch_utils.sh":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update sketch_utils.sh":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update sketch_utils.sh":
    • summary looks empty
    • type/action looks empty
  • the commit message "Upload event file":
    • summary looks empty
    • type/action looks empty
  • the commit message "add LittleFS as partition type (#9354)":
    • summary looks empty
    • type/action looks empty
  • the commit message "add log messages":
    • summary looks empty
    • type/action looks empty
  • the commit message "changed json format and removed moving the file":
    • summary looks empty
    • type/action looks empty
  • the commit message "debug test":
    • summary looks empty
    • type/action looks empty
  • the commit message "fix chunk index in filename":
    • summary looks empty
    • type/action looks empty
  • the commit message "fix sizes file name":
    • summary looks empty
    • type/action looks empty
  • the commit message "fix(dns): Fix IPv6-only network, by checking IPv6 first if you have public address (#9443)":
    • summary appears to be too long
  • the commit message "fix(ethernet): move event listener earlier to avoid missing event ETH_CONNECTED (#9481)":
    • summary appears to be too long
  • the commit message "fix(tls): Enable IPv6 support in ssl_client connect (#9470)":
    • body's lines must not be longer than 100 characters
  • the commit message "fix: HW CDC write() (#9401)":
    • body's lines must not be longer than 100 characters
  • the commit message "make pr and master dirs":
    • summary looks empty
    • type/action looks empty
  • the commit message "save sizes in push workflow":
    • summary looks empty
    • type/action looks empty
  • the commit message "save the event.json artifact":
    • summary looks empty
    • type/action looks empty
  • the commit message "update bash":
    • summary looks empty
    • type/action looks empty
  • the commit message "update bash":
    • summary looks empty
    • type/action looks empty
  • the commit message "update bash":
    • summary looks empty
    • type/action looks empty
  • the commit message "update workflows":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).
⚠️ Please consider squashing your 73 commits (simplifying branch history).
⚠️ The Pull Request description looks very brief, please check if more details can be added.
⚠️

The source branch "Deltas_testing" incorrect format:

  • contains uppercase letters. This can cause troubles on case-insensitive file systems (macOS).
    Please rename your branch.
Messages
📖 This PR seems to be quite large (total lines of code: 122221), you might consider splitting it into smaller PRs

👋 Hello P-R-O-C-H-Y, we appreciate your contribution to this project!

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 96758a7

SuGlider and others added 20 commits April 16, 2024 16:44
@SuGlider @P-R-O-C-H-Y
fix: HW CDC write() (espressif#9401)
f864a99 
When writing a stream of data to the HW CDC of S3/C3/C6/H2, the SoC looses some bytes and don't send them all.

This fix makes it work fine.
@P-R-O-C-H-Y
fix(sd): AquireSPI lock in sdcard_uninit (espressif#9468)
45f2631
@sgryphon @P-R-O-C-H-Y
fix(tls): Enable IPv6 support in ssl_client connect (espressif#9470)
6adb0d0 
Similar to NetworkClient, check the family of the passed in address and configure the socket and socket address accordingly, for both IPv6 and IPv4 support.
@sgryphon @P-R-O-C-H-Y
feat(dns): Check type of IP addresses and clear DNS cache if they cha…
c15053f 
…nged (espressif#9476)
@SuGlider @P-R-O-C-H-Y
fix: USB HID Keyboard raw report (espressif#9473)
53f902f
@me-no-dev @P-R-O-C-H-Y
feat(wifi): Add support for NAPT to WIFI AP (espressif#9478)
f9a06ec 
Allows another interface's connection to be shared to the AP
@s-hadinger @P-R-O-C-H-Y
fix(ethernet): move event listener earlier to avoid missing event `ET…
a8145f7 
…H_CONNECTED` (espressif#9481)

* Ethernet: Move event listener earlier

* fix(ethernet): move network listener after initNetif
@nathannau @me-no-dev @P-R-O-C-H-Y
Handle large octet-stream (master branch) (espressif#9440)
e546d44 
* Handle large octet-stream

* Add exemple Upload Huge File

* Remove unuse function printDirectory

* Fix upload path

* Simplify and generalize the body parsing.

* Create .skip.esp32h2

---------

Co-authored-by: me-no-dev <hristo@espressif.com>
@SuGlider @P-R-O-C-H-Y
Change name to HWCDC_Events.ino (From HWSerial_Events.ino) (espressif…
2d44e06 
…#9483)

* Create HWCDC_Events.ino

* Delete libraries/ESP32/examples/HWSerial_Events/.skip.esp32

* Delete libraries/ESP32/examples/HWSerial_Events/.skip.esp32s2

* Delete libraries/ESP32/examples/HWSerial_Events/HWSerial_Events.ino

* Create .skip.esp32

* Create .skip.esp32s2

* Fixes HWCDC_Events.ino

* Fixes CI for S3
@sgryphon @P-R-O-C-H-Y
fix(dns): Fix IPv6-only network, by checking IPv6 first if you have p…
1f8e9e4 
…ublic address (espressif#9443)

Work around because AF_UNSPEC does not check available addresses when
determining result.

If you have a global scope IPv6 address, then first check for IPv6 DNS result;
if you don't have an IPv6, or there is no IPv6 result, then check IPv4.

This allows IPv6-only networks to connect to dual-stack destinations, as they
will get the IPv6 address (rather than the unusable IPv4).

It also means a dual-stack host to a dual-stack destination will preference
IPv6.

There is no effect if you are on an IPv4-only network, or it is an IPv4-only
destination.
@me-no-dev @P-R-O-C-H-Y
IDF release/v5.1 (espressif#9498)
f30de01 
* fix(ble): rename esp_ble_gap_ext_adv_report_t

* IDF release/v5.1 d23b7a0361
@lucasssvaz @P-R-O-C-H-Y
fix(ftm): Fix compilation warning (espressif#9508)
5fc8cd5
@eltociear @P-R-O-C-H-Y
Fix typo in Updater.cpp (espressif#9511)
155107a 
arguement -> argument
@evgenimelan @P-R-O-C-H-Y
change(roboheart): Update of LED_ROBOHEART in RoboHeart Hercules pins…
449330e 
…_arduino.h (espressif#9494)
@lucasssvaz @P-R-O-C-H-Y
refactor(udp_server): Convert script from Python 2 to 3 (espressif#9513)
1a7adb1
@lucasssvaz @pre-commit-ci-lite
@SuGlider @P-R-O-C-H-Y
Style Checker and Pre-commit hook CI (espressif#9132)
f82ddcd 
* Add Config

* Add Cache and remove pre-commit action

* [pre-commit.ci lite] apply automatic fixes

* Remove freeze

* Fix

* Update action

* Use latest stable Python 3 version

* Improve caching

* Improve cache tag

* Improve bot message

* Fix flake and make Vale manual

* Add filter

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
@lucasssvaz @pre-commit-ci-lite
@SuGlider @P-R-O-C-H-Y
Refactor repository with pre-commit hooks (espressif#9515)
63e613d 
* Add Config

* Add Cache and remove pre-commit action

* [pre-commit.ci lite] apply automatic fixes

* Remove freeze

* Fix

* Update action

* Use latest stable Python 3 version

* Improve caching

* Improve cache tag

* Improve bot message

* fix(typos): Fix typos

* fix(typos): Fix more typos

* refactor(udp_server): Convert script from Python 2 to 3

* Fix whitespace

* Clang-format fixes

* Prettier fixes

* Black formatting

* Manual fixes

* Line endings

* Fix flake and make Vale manual

* Fix flake and reformat

---------

Co-authored-by: pre-commit-ci-lite[bot] <117423508+pre-commit-ci-lite[bot]@users.noreply.github.com>
Co-authored-by: Rodrigo Garcia <rodrigo.garcia@espressif.com>
@Jason2866 @lucasssvaz @P-R-O-C-H-Y
add LittleFS as partition type (espressif#9354)
215df20 
Co-authored-by: Lucas Saavedra Vaz <32426024+lucasssvaz@users.noreply.github.com>
@lucasssvaz @P-R-O-C-H-Y
feat(doc): Add note about default pin changes to migration guide (esp…
8d2d8ab 
…ressif#9507)
@P-R-O-C-H-Y
debug test
96758a7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@P-R-O-C-H-Y @SuGlider @sgryphon @me-no-dev @s-hadinger @nathannau @lucasssvaz @eltociear @evgenimelan @Jason2866