Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bsp(esp_bsp_devkit): New generic BSP without LCD and touch (BSP-528) #390

Merged
merged 1 commit into from
Sep 27, 2024
Merged

bsp(esp_bsp_devkit): New generic BSP without LCD and touch (BSP-528) #390

merged 1 commit into from
Sep 27, 2024

Conversation

espzav
Copy link
Collaborator

@espzav espzav commented Sep 10, 2024 •
edited
Loading

Checklist for new Board Support package or Component

  • Component contains License
  • Component contains README.md
  • [ ] Project README.md updated
  • Component contains idf_component.yml file with url field defined
  • Component was added to CI upload job
  • New files were added to CI build job
  • New BSP definitions added to bsp_ext.py
  • [ ] BSP was added to SquareLine
  • New BSP supports IDF v4.4.x and later releases
  • [ ] Optional: Component contains unit tests
  • CI passing

Change description

  • This is generic BSP without LCD and touch
  • I would like to write blog post about generic BSP and I want to mension this too
  • Please, check the name of this BSP - is it ok? Or propose another please. (Lite, Simple, etc..)

@espzav
Copy link
Collaborator Author

espzav commented Sep 10, 2024

@igrr @tore-espressif PTAL

@espzav espzav changed the title bsp(esp_bsp_generic_lite): New generic BSP without LCD and touch. bsp(esp_bsp_generic_lite): New generic BSP without LCD and touch (BSP-528) Sep 10, 2024
@espzav espzav changed the title bsp(esp_bsp_generic_lite): New generic BSP without LCD and touch (BSP-528) bsp(esp_bsp_devkit): New generic BSP without LCD and touch (BSP-528) Sep 19, 2024
igrr
igrr reviewed Sep 19, 2024
View reviewed changes
bsp/esp_bsp_devkit/README.md Outdated Show resolved Hide resolved
igrr
igrr reviewed Sep 19, 2024
View reviewed changes
examples/bsp_ext.py Outdated Show resolved Hide resolved
@espzav
Copy link
Collaborator Author

espzav commented Sep 19, 2024

@igrr Thank you for review. Fixed.

@espzav
Copy link
Collaborator Author

espzav commented Sep 26, 2024

Hi, my article about Generic/DevKit BSP was merged today and it will be show tomorrow. I forgot, that this is not merged yet. Please could you help me with review today? @igrr @tore-espressif I am sorry

@espzav espzav merged commit 81a20ca into master Sep 27, 2024
16 checks passed
@espzav espzav deleted the bsp/generic_lite branch September 27, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igrr igrr igrr left review comments

@tore-espressif tore-espressif tore-espressif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@espzav @igrr @tore-espressif