Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bsp): fix idf5.0 adc build with unknown type error #394

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

leeebo
Copy link
Collaborator

@leeebo leeebo commented Sep 20, 2024

ESP-BSP Pull Request checklist

Note: For new BSPs create a PR with this link.

  • Version of modified component bumped
  • CI passing

Change description

  • Explicit include esp_adc/adc_cali_scheme.h in BSP header to support IDF 5.0

bsp like esp32_s3_usb_otg esp32_s3_lcd_ev_board build under IDF 5.0 always failed with error:

.../managed_components/espressif__esp32_s3_usb_otg/esp32_s3_usb_otg_idf5.c:14:8: error: unknown type name 'adc_cali_handle_t'
   14 | static adc_cali_handle_t bsp_adc_cali_handle; /* ADC1 calibration handle */

...

error: unknown type name 'adc_cali_curve_fitting_config_t'

The root cause is esp_adc/adc_oneshot.h in IDF 5.0 not explicit include esp_adc/adc_cali_scheme.h

While IDF 5.1 and later versions include esp_adc/adc_cali_scheme.h in esp_adc/adc_oneshot.h

@CLAassistant
Copy link

CLAassistant commented Sep 20, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@tore-espressif tore-espressif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @leeebo !

@@ -32,7 +32,7 @@
* Add new APIs for spiffs, audio in `bsp/esp32_s3_lcd_ev_board.h`
* Add new APIs for ADC in `bsp/esp32_s3_lcd_ev_board.h`

## v3.0.0 - 2023-12-02
## v2.1.0 - 2023-12-02
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Lzw655 PTAL! , there is no v3.0.0 released, it a typo?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Thank you for correcting the error!

Copy link
Collaborator

@espzav espzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leeebo thank you for this fix! LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants