Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return err code when a Ringbuffer is full or inaccessible #190

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

drosen-taranawireless
Copy link
Contributor

esp_rb_write_by_kernel() returns the number of bytes written; and it is called repeatedly until the entire length of the packet has been transferred. In the case of a full/inaccessible ringbuffer, it was returning zero, causing the caller to invoke the function in a tight loop. Fixed to return -EFAULT.

esp_rb_write_by_kernel() returns the number of bytes written; and
it is called repeatedly until the entire length of the packet has
been transferred. In the case of a full/inaccessible ringbuffer, it
was returning zero, causing the caller to invoke the function in
a tight loop. Fixed to return -EFAULT.
@mantriyogesh
Copy link
Collaborator

Hello @drosen-taranawireless

thank you for all your efforts and the solution to issue.
We will merge it in short time.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants