Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cmake file for gprof (AEGHB-792) #399

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

henrywiechert
Copy link
Contributor

In case CONFIG_GPROF_ENABLE is not configured, this error occured:
"target_compile_options may only set INTERFACE properties on INTERFACE"

@CLAassistant
Copy link

CLAassistant commented Aug 27, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

github-actions bot commented Aug 27, 2024

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello henrywiechert, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 8dd4474

@github-actions github-actions bot changed the title Fix cmake file for gprof Fix cmake file for gprof (AEGHB-792) Aug 27, 2024
In case CONFIG_GPROF_ENABLE is not configured, this error occured:
"target_compile_options may only set INTERFACE properties on INTERFACE"
@henrywiechert
Copy link
Contributor Author

henrywiechert commented Aug 28, 2024

Additional information:

When CONFIG_GPROF_ENABLE is not set, the SRCS variable is empty. In such case, idf_component_register() assumes the component to be an INTERFACE and uses
add_library(${component_lib} INTERFACE)
This causes a problem later, when cu_pkg_define_version() uses target_compile_options(<COMPONENT_LIB> PUBLIC), which is not allowed for INTERFACE components.

Feel free to add this information to the final commit message.

@leeebo
Copy link
Collaborator

leeebo commented Sep 19, 2024

@henrywiechert The fix looks good to me, thanks!

Copy link
Collaborator

@leeebo leeebo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sha=8dd4474ee1d43b96a444644906a060dbfe59ff89

@leeebo
Copy link
Collaborator

leeebo commented Sep 23, 2024

sha=8dd4474ee1d43b96a444644906a060dbfe59ff89

@zhanzhaocheng zhanzhaocheng merged commit de6abfb into espressif:master Sep 24, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants