Give a option to make on_level ATTRIBUTE_FLAG_NONVOLATILE (CON-1431)

[Haerteleric]

Is your feature request related to a problem? Please describe.
On Level Attribute (Level Control Cluster) is reset to init values after each power cycle.

Describe the solution you'd like
allow ATTRIBUTE_FLAG_NONVOLATILE for that attribute.

Describe alternatives you've considered
give us a esp_matter func to manually set the ATTRIBUTE_FLAG_NONVOLATILE of a Attribute

Additional context
...

[jonsmirl]

Current Level is required by the spec to be non-volatile.

I just tried the Espessif Light Demo and it does not appear to be preserving CurrentLevel like it is supposed to do.
You don't need option, this appears to be broken in esp-matter.

[jadhavrohit924]

@Haerteleric We cannot change the quality of an attribute; doing so would violate the Matter spec.

I just tried the Espessif Light Demo and it does not appear to be preserving CurrentLevel like it is supposed to do.

@jonsmirl We will look into this.

[jadhavrohit924]

@jonsmirl Light Demo example has the StartUpCurrentLevel attribute on the LevelControl cluster that's why CurrentLevel's value is being overridden by StartUpCurrentLevel's value. If you don’t want to overwrite the CurrentLevel's value, you can define IGNORE_LEVEL_CONTROL_CLUSTER_START_UP_CURRENT_LEVEL in your application.

[Haerteleric]

i am not talking about the "CurrentLevel" (0x0000) but the "OnLevel" (0x0011) created in

esp_matter::cluster::level_control::attribute::create_on_level
(esp_matter_attribute.cpp:1136)

[jadhavrohit924]

Yes, as I said in the above comments. We cannot change the quality of an attribute, doing so would violate the Matter spec.

[Haerteleric]

why should OnLevel be Volatile ?

That does not make sense. If a user sets a TurnOn Brigthness (not startup brightness) it should not default to Max Brightness everytime the device gets power cycled.

That would blind people.

[Haerteleric]

see 1.6.4.1.1. Effect of On/Off Commands on the CurrentLevel Attribute

Matter Application Cluster
Specification

[shubhamdp]

@Haerteleric I think you should be using StartUpCurrentLevel and not OnLevel

1.6.6.15. StartUpCurrentLevel Attribute
This attribute SHALL indicate the desired startup level for a device when it is supplied with power and this level SHALL be reflected in the CurrentLevel attribute.

[shubhamdp]

@Haerteleric any update on the issue?

[Haerteleric]

The StartUpCurrentLevel is for power-on-behaviour imo.

The OnLevel is when the light EP was Off (but device is powered and on Network) and got turned on by a toggle or turn on command.

[shubhamdp]

@Haerteleric That is correct, and you should use StartUpCurrentLevel for re-storing level value on power cycle. I think that was the original question you asked in the description.

Is there still a problem? If not can you please close the issue.

[Haerteleric]

OnLevel is volitile though and has to be set after every PowerCycle atm. I don't think this is the way it should behave.

[Haerteleric]

Setting On Level:

On Level after PowerCycle:

[Haerteleric]

the stack resets the OnLevel value after every reboot to the default setting.

[shubhamdp]

the stack resets the OnLevel value after every reboot to the default setting.

That is expected, as per the specification, OnLevel is a volatile attribute. If you want to mess with spec compliance please add ATTRIBUTE_FLAG_NONVOLATILE below.

esp-matter/components/esp_matter/esp_matter_attribute.cpp

Lines 1195 to 1200 in cb21664

	attribute_t *create_on_level(cluster_t *cluster, nullable<uint8_t> value)
	{
	return esp_matter::attribute::create(cluster, LevelControl::Attributes::OnLevel::Id,
	ATTRIBUTE_FLAG_WRITABLE | ATTRIBUTE_FLAG_NULLABLE,
	esp_matter_nullable_uint8(value));
	}

NOTE: I won't recommend you to make that change, but if you want to break the specification compliance, please go ahead.

[Haerteleric]

Could you please refer me to the specification sections where this is defined?

Cause i can't find it.

[Haerteleric]

the code section you linked is about the node_label ?!?

the stack resets the OnLevel value after every reboot to the default setting.

That is expected, as per the specification, OnLevel is a volatile attribute. If you want to mess with spec compliance please add ATTRIBUTE_FLAG_NONVOLATILE below.

esp-matter/components/esp_matter/esp_matter_attribute.cpp

Lines 189 to 195 in cb21664

	attribute_t *create_node_label(cluster_t *cluster, char *value, uint16_t length)
	{
	VerifyOrReturnValue(length <= k_max_node_label_length, NULL, ESP_LOGE(TAG, "Could not create attribute, string length out of bound"));
	return esp_matter::attribute::create(cluster, BasicInformation::Attributes::NodeLabel::Id,
	ATTRIBUTE_FLAG_WRITABLE | ATTRIBUTE_FLAG_NONVOLATILE,
	esp_matter_char_str(value, length), k_max_node_label_length);
	}

NOTE: I won't recommend you to make that change, but if you want to break the specification compliance, please go ahead.

[shubhamdp]

Sorry for the cut-paste mistake, I have updated the link in the comment above.

Please check Matter Application Cluster Specification Section 1.6.6. Attributes. Do check the Quality Column, X is nullable and N is non-volatile.

[Haerteleric]

You are right. I was in the wrong.

I would like to apologize for my tone.