Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing chips features #154

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Add missing chips features #154

merged 2 commits into from
Sep 11, 2024

Conversation

RushikeshPatange
Copy link
Contributor

@RushikeshPatange RushikeshPatange commented Sep 6, 2024 •
edited
Loading

What Does This MR Do ?

  • It will add missing chip features for ESP32-C3 and ESP32-C6 in getChipFeatures
  • It will add helper functions required by getChipFeatures for ESP32-C3, ESP32-S2 and ESP32-S3

Reference's:

@RushikeshPatange RushikeshPatange marked this pull request as ready for review September 9, 2024 12:52
brianignacio5
brianignacio5 approved these changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@brianignacio5 brianignacio5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thank you for the contribution!

@brianignacio5 brianignacio5 merged commit ba9fc98 into espressif:main Sep 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianignacio5 brianignacio5 brianignacio5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RushikeshPatange @brianignacio5