Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement SwitchClause #117

Merged
merged 3 commits into from
Feb 6, 2024
Merged

Conversation

horw
Copy link
Member

@horw horw commented Jan 17, 2024

Implemented SwitchClause to enable the ability to use the following manifest format:

folder_foo:
  depends_components:
    - if: IDF_VERSION == "5.2.0":
      content: ["esp_eth"]
    - if: IDF_VERSION == "5.3.0":
      content: ["esp_wifi"]
    - default: ["esp_eth", "esp_wifi"]

or

folder_foo:
  depends_components:
    - esp_eth_1
    - esp_eth_2

closes #105

@horw horw force-pushed the feat/switch_statement branch from 6fc5f2e to e3ecded Compare January 17, 2024 09:48
@horw horw requested a review from hfudev January 17, 2024 10:04
@horw horw force-pushed the feat/switch_statement branch 2 times, most recently from 7fa7263 to 178a749 Compare January 18, 2024 10:39
@horw horw force-pushed the feat/switch_statement branch from 178a749 to 01c812a Compare February 5, 2024 03:51
@horw
Copy link
Member Author

horw commented Feb 5, 2024

@hfudev Hi! I have updated the documentation for the switch statement. Please take a look

@horw horw force-pushed the feat/switch_statement branch 2 times, most recently from 07a5f03 to 5dae444 Compare February 5, 2024 03:58
Copy link
Member

@hfudev hfudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this nice feature.

left a few comments, and could you help add some tests on combining the depends_components+ together with the switch clauses?

docs/manifest.md Outdated Show resolved Hide resolved
docs/manifest.md Outdated Show resolved Hide resolved
docs/manifest.md Outdated Show resolved Hide resolved
idf_build_apps/manifest/manifest.py Outdated Show resolved Hide resolved
idf_build_apps/manifest/manifest.py Outdated Show resolved Hide resolved
idf_build_apps/manifest/manifest.py Outdated Show resolved Hide resolved
idf_build_apps/manifest/manifest.py Show resolved Hide resolved
idf_build_apps/manifest/manifest.py Show resolved Hide resolved
@horw horw force-pushed the feat/switch_statement branch 3 times, most recently from efda58a to a28b4dd Compare February 6, 2024 05:59
@horw horw requested a review from hfudev February 6, 2024 06:30
Copy link
Member

@hfudev hfudev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. kudos to the nice test cases. LGTM!

@horw horw force-pushed the feat/switch_statement branch from a28b4dd to e7899f5 Compare February 6, 2024 09:30
@horw horw force-pushed the feat/switch_statement branch from e7899f5 to 98139a0 Compare February 6, 2024 09:35
@hfudev hfudev merged commit 1e843c3 into espressif:main Feb 6, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support if clauses in depends_components and depends_filepatterns (RDT-628)
2 participants