Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unset CLI argument wrongly overwrite config file settings with default value #166

Merged

Conversation

hfudev
Copy link
Member

@hfudev hfudev commented Sep 27, 2024

No description provided.

@hfudev hfudev self-assigned this Sep 27, 2024
@hfudev hfudev force-pushed the fix/unset_cli_args_overwrite_config_files_with_default_value branch 2 times, most recently from 2e60651 to 7aa6805 Compare September 27, 2024 10:54
@hfudev hfudev force-pushed the fix/unset_cli_args_overwrite_config_files_with_default_value branch from 7aa6805 to 87f3004 Compare September 27, 2024 11:14
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
idf_build_apps
   __main__.py330%4–9
   app.py5238185%206, 251, 260–262, 294, 306, 323, 364–365, 368, 378–379, 390–393, 453–458, 478, 516, 572–580, 590–591, 601, 619–620, 622, 638–647, 663–701, 706–707, 711–712, 723–725, 731, 832–840, 850–880, 884–894, 985–991, 994, 1016
   args.py2753189%291, 298, 319–324, 334–339, 505, 508–509, 515, 525–527, 530, 555–556, 559–560, 689–690, 751, 753, 813, 832–842
   autocompletions.py292417%16–23, 31–54
   constants.py63986%20–21, 33–38, 47–48, 61–62
   finder.py83693%78–79, 149, 166–168
   log.py48492%37, 50, 55, 80
   main.py1996567%76–80, 94–99, 140–144, 174, 198–200, 204, 209–222, 237–240, 251–276, 366–373, 382–383, 396, 404–418, 422–423, 429–431
   session_args.py54787%46–50, 56, 70
   utils.py1882388%26, 35, 113, 130–131, 151–155, 203, 246, 273–279, 292–295, 314–315, 380
idf_build_apps/junit
   report.py93990%82, 92, 109–111, 137, 144–145, 170
   utils.py291066%18, 26–35
idf_build_apps/manifest
   if_parser.py109595%62, 99, 105, 169, 174
   manifest.py2191195%90, 92, 139, 161, 211–216, 306, 337–338, 357, 401
idf_build_apps/vendors
   pydantic_sources.py61789%35, 47, 66–69, 108, 115
TOTAL210329586% 

Tests Skipped Failures Errors Time
108 0 💤 0 ❌ 0 🔥 15m 44s ⏱️

@hfudev hfudev merged commit 5e18626 into main Sep 27, 2024
8 checks passed
@hfudev hfudev deleted the fix/unset_cli_args_overwrite_config_files_with_default_value branch September 27, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant