Support absolute values for variationRange in sensitivityCalculation
#731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sure, it is coming :) |
|
Aaaah sorry, didn't see that you did not request the review, yet :) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #731 +/- ##
==========================================
+ Coverage 86.11% 88.35% +2.24%
==========================================
Files 29 29
Lines 2593 2757 +164
==========================================
+ Hits 2233 2436 +203
+ Misses 360 321 -39 ☔ View full report in Codecov by Sentry. |
I agree. Given the scope of recent changes, I propose raising a separate issue to update the vignettes. |
Merge branch 'main' of https://github.com/esqLABS/esqlabsR into absolute-parameter-range # Conflicts: # tests/testthat/test-sensitivity-calculation.R
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhanced
sensitivityCalculationto acceptvariationRangeas bothabsoluteandrelativevalues. Added support for passingvariationRangeas a list, allowing individual variations for each parameter inparameterPaths. Introduced thevariationTypeparameter to specify whether the variationRange is applied as absolute or relative values.Closes #623
Closes #621