Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

202411 feedback lp 272 #498

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Conversation

anthonylindsay
Copy link
Collaborator

@anthonylindsay anthonylindsay commented Nov 11, 2024

Replaces feedback form with the one from Love Essex.
Installs accompanying custom webform module to provide a referrer and some css
https://eccservicetransformation.atlassian.net/browse/LP-271

@Polynya
Copy link
Collaborator

Polynya commented Nov 13, 2024

/start

Copy link

Starting Review App.

@Polynya
Copy link
Collaborator

Polynya commented Nov 13, 2024

There are several issues reported by CodeSniffer. Please run ddev composer tests-required

@anthonylindsay
Copy link
Collaborator Author

codesniffer issues addressed.
I ran ddev composer tests-required but have no idea what I'm looking at? It doesn't appear to have anything to do with the change at hand?

@Polynya
Copy link
Collaborator

Polynya commented Nov 13, 2024

composer tests-required runs composer audit which has reported several security issues. They aren't related to your change but still stop the pipeline before the containers are built.
The issues are all fixed by Drupal core 10.3.8 which I've done in this PR #499
If you can approve it, I'll merge it and you can pull develop into your branch.

@anthonylindsay
Copy link
Collaborator Author

Uh, I don't think I should get involved in your well honed maintenance workflow. Approving PRs feels a bit out of the bounds of my remit. This PR can wait.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants