LP-118: Use ref name from PR in comment workflow. #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Starting reviewapp |
|
Stopping reviewapp and clearing up |
|
Starting reviewapp |
siliconmeadow
approved these changes
Apr 30, 2024
Comment on lines
-16
to
-27
| - name: Set latest commit status as pending | ||
| uses: myrotvorets/set-commit-status-action@2 | ||
| with: | ||
| sha: ${{ steps.comment-branch.outputs.head_sha }} | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| status: pending | ||
|
|
||
| - name: Checkout PR branch | ||
| uses: actions/checkout@v3 | ||
| with: | ||
| ref: ${{ steps.comment-branch.outputs.head_ref }} | ||
|
|
There was a problem hiding this comment.
What exactly were these steps indended for? Or why aren't they needed?
There was a problem hiding this comment.
I copied from an example without really checking. (It checked out the branch and then deployed it somewhere,)
|
Stopping reviewapp and clearing up |
|
Stopped reviewapp and cleared up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include a summary of what this merge request involves (*)
in an issue_comment workflow:
Call out any relevant implementation decisions
https://github.com/xt0rted/pull-request-comment-branch?tab=readme-ov-file#outputs
Why have you taken the approach?
Any particular problem areas?
The issue_comment workflow uses the develop branch so it's not possible to check these changes work until the branch has been merged to develop.
If necessary, please include any relevant screenshots (If not already available on the JIRA ticket)
This PR has been tested in the following browsers