Does not correctly tag digest pinned container image

[jetersen]

Given image using tag with digest pinned it does not correct upload the image with tag v2.13.0 and gets deleted by untagged images policy 😅

argo-cd:
  global:
    image:
      repository: quay.io/argoproj/argocd
      tag: v2.13.0@sha256:5806aac0c6e4d04aeeb385a218cfeaeb4daaab9bfbc2b41f908788eb5b3d2909

[jetersen]

This method should properly return normalizedName, tag, digest and than if tag and digest is not nil. Tag the digest after having copied it 🤔

k8s-image-swapper/pkg/webhook/image_swapper.go

Lines 150 to 165 in 72a2a04

	func imageNamesWithDigestOrTag(imageName string) (string, error) {
	ref, err := reference.ParseNormalizedNamed(imageName)
	if err != nil {
	return "", err
	}
	_, isTagged := ref.(reference.NamedTagged)
	canonical, isDigested := ref.(reference.Canonical)
	if isTagged && isDigested {
	canonical, err = reference.WithDigest(reference.TrimNamed(ref), canonical.Digest())
	if err != nil {
	return "", err
	}
	imageName = canonical.String()
	}
	return imageName, nil
	}