Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the Azure storage mappings double-slash issue permanently #1804

Open
jshearer opened this issue Dec 2, 2024 · 0 comments
Open

Fix the Azure storage mappings double-slash issue permanently #1804

jshearer opened this issue Dec 2, 2024 · 0 comments
Assignees

Comments

@jshearer
Copy link
Contributor

jshearer commented Dec 2, 2024

Currently, Azure storage mappings generate fragment files with a double slash in their names. This is caused by this line including a trailing /:

"azure-ad://{}/{}/{}/{}/",

We can't just remove that slash, as that would cause the Azure fragment storage logic to generate incorrect signed URLs. So:

  • Fix the Gazette azure storage mapping logic to return correct signed URLs for fragments that either contain a single, or a double slash
  • Once that's live, then update the above to remove the trailing slash and start generating fragments with out a double slash

This won't solve the problem of having existing fragment files out there with double slashes in them, but it should allow us to start writing correct filenames, while retaining backwards compatibility with the existing ones.

@jshearer jshearer self-assigned this Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant