-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add two new columns to connectors
for UI to show/hide properties
#1556
Add two new columns to connectors
for UI to show/hide properties
#1556
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, I think you've been led astray by our out-of-date docs on migrations. Sorry. The way to do migrations now is to add a new migration and run alter table
commands to add the columns. You might try using the pgadmin
workflow from those docs in order to generate the migration, though I'm not sure whether it still works (which is why we switched workflows).
I think we might also want these columns on connector_tags
instead of connectors. We have things like autodiscover_interval
on connector_tags
, and having it there allows us to set it automatically if we ever want to. Would that work from a front-end perspective?
Ahhh - I thought that was how we did it but saw when we added GCP stuff we just updated existing migrations. Yeah - putting them on tags works for me. I was wondering how we'd want to handle if we updated a connector to make things like interval no longer needed. |
updating name as requested
…/add_interval_col_to_connectors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Description:
Added two new columns to the
connectors
table.estuary/ui#1194 / #1552
capture_interval
when
null
the UI will hide the interval input on the Capture edit/create workflowwhen a value the UI will show the interval input and default it to the provided value
estuary/ui#1219
disable_backfill
when
false
the UI will show backfillwhen
true
the UI will hide backfillWorkflow steps:
Run a migration on Supabase
Documentation links affected:
n/a
Notes for reviewers:
Ran
supabase stop
andsupabase start
to make sure the script ranThis change is