Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add two new columns to connectors for UI to show/hide properties #1556

Merged
merged 10 commits into from
Aug 27, 2024

Conversation

travjenkins
Copy link
Member

@travjenkins travjenkins commented Aug 14, 2024

Description:

Added two new columns to the connectors table.

estuary/ui#1194 / #1552
capture_interval
when null the UI will hide the interval input on the Capture edit/create workflow
when a value the UI will show the interval input and default it to the provided value

estuary/ui#1219
disable_backfill
when false the UI will show backfill
when true the UI will hide backfill

Workflow steps:

Run a migration on Supabase

Documentation links affected:

n/a

Notes for reviewers:

Ran supabase stop and supabase start to make sure the script ran

...
Applying migration 48_storage_mapping_directive.sql...
Applying migration 49_tenant_hide_preview.sql...
Applying migration 50_controllers.sql...
Applying migration 51_backfill_controllers.sql...
Applying migration 52_extend_pg_net_timeout.sql...
Applying migration 53_rls_perf.sql...
Applying migration 54_user_info_summary.sql...
Applying migration 55_inferred_schema_triggers.sql...
Applying migration 56_connector_tags_control_flags.sql...
Seeding data supabase/seed.sql...
Started supabase local development setup.
...

image


This change is Reviewable

Copy link
Member

@psFried psFried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, I think you've been led astray by our out-of-date docs on migrations. Sorry. The way to do migrations now is to add a new migration and run alter table commands to add the columns. You might try using the pgadmin workflow from those docs in order to generate the migration, though I'm not sure whether it still works (which is why we switched workflows).

I think we might also want these columns on connector_tags instead of connectors. We have things like autodiscover_interval on connector_tags, and having it there allows us to set it automatically if we ever want to. Would that work from a front-end perspective?

@travjenkins
Copy link
Member Author

Ahhh - I thought that was how we did it but saw when we added GCP stuff we just updated existing migrations.

Yeah - putting them on tags works for me. I was wondering how we'd want to handle if we updated a connector to make things like interval no longer needed.

@travjenkins travjenkins requested a review from psFried August 26, 2024 14:09
Copy link
Member

@psFried psFried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@travjenkins travjenkins added the change:planned This is a planned change label Aug 27, 2024
@travjenkins travjenkins merged commit f72c01e into master Aug 27, 2024
3 checks passed
@travjenkins travjenkins deleted the travjenkins/feature/add_interval_col_to_connectors branch December 9, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:planned This is a planned change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants