Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go_openrpc_reflect: add nil checks around fn.Recv use #10

Merged
merged 2 commits into from
Aug 29, 2022

Conversation

meowsbits
Copy link
Member

Toward resolving the issue documented at
#9

Date: 2022-08-23 15:11:10-05:00
Signed-off-by: meows b5c6@protonmail.com

PS. Blame Copilot for the formatting fixes

Toward resolving the issue documented at
#9

Date: 2022-08-23 15:11:10-05:00
Signed-off-by: meows <b5c6@protonmail.com>
before checking the first output param
Copy link
Member

@ziogaschr ziogaschr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
This branch works fine when running core-geth tests.

@meowsbits meowsbits merged commit ba5a99f into master Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants