Initial version of the configuration autodetection script #240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 18, 2024 10:25
ekouts
reviewed
Oct 18, 2024
ekouts
reviewed
Oct 23, 2024
ekouts
requested changes
Oct 24, 2024
teojgo
requested changes
Oct 29, 2024
|
cscs-ci run alps-todi-cpe |
|
cscs-ci run alps-todi-uenv |
1 similar comment
|
cscs-ci run alps-todi-uenv |
ekouts
reviewed
Nov 8, 2024
ekouts
approved these changes
Nov 8, 2024
jgphpc
reviewed
Nov 12, 2024
config/utilities/constants.py
Outdated
| UNDERLINE = '\033[4m' | ||
|
|
||
|
|
||
| RFM_DOCUMENTATION = {'modules': 'https://reframe-hpc.readthedocs.io/en/stable/config_reference.html#config.systems.modules', |
There was a problem hiding this comment.
instead of repeating https://..., can you use a variable ?
something like:
url = 'https://reframe-hpc.readthedocs.io/en/stable/'
...
'modules' = f'{url}/config_reference.html#config.systems.modules',
jgphpc
reviewed
Nov 12, 2024
config/utilities/constants.py
Outdated
| fi | ||
|
|
||
| if check_lmod; then | ||
| # Check if it's available as a module, regardless of 'which' result |
There was a problem hiding this comment.
Suggested change
| # Check if it's available as a module, regardless of 'which' result | |
| # Check if it is available as a module, regardless of 'which' result |
jgphpc
reviewed
Nov 12, 2024
config/utilities/constants.py
Outdated
|
|
||
| # Output the total memory | ||
| echo "Total memory: $total_memory" | ||
| ''' |
jgphpc
reviewed
Nov 12, 2024
| import subprocess | ||
|
|
||
|
|
||
| class ModulesSystem(abc.ABC): |
jgphpc
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic detection of the system configuration to create the reframe configuration file. User input is required to generate the final reframe config_file for the system:
<system_name>_config.pyand<system_name>_config.json.