Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override single field only when using craft.seo.custom #488

Open
BigglesZX opened this issue Oct 24, 2024 · 0 comments
Open

Override single field only when using craft.seo.custom #488

BigglesZX opened this issue Oct 24, 2024 · 0 comments

Comments

@BigglesZX
Copy link

BigglesZX commented Oct 24, 2024

I have implemented code similar to the solution posted in #66 to provide default social images if they aren't specified on the entry. However when using craft.seo.custom I have to re-specify the title, description and any other fields I want to output, otherwise they are empty. In other words the custom parameters/object are not merged with the site/entry defaults, they replace them.

There is an issue with double-suffixes being applied to my titles if I for example do this:

{% set seo = craft.seo.custom(
    entry.seo.title,
    entry.seo.description,
    # ... custom image stuff
) %}

...because entry.seo.title has already undergone some processing to add the suffix, it's not ideal to re-use it in this way.

Therefore it would be really useful if there was an option to provide only overrides to the craft.seo.custom function and not a complete replacement configuration object.

If this is already possible and I've just missed it somehow I would appreciate a pointer. Thanks!

Additional info

  • Craft version: 5.4.9
  • SEO version: 5.0.0
  • PHP version: 8.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant