Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor bindings #64

Merged
merged 5 commits into from
Jun 12, 2024
Merged

Refactor bindings #64

merged 5 commits into from
Jun 12, 2024

Conversation

pcw109550
Copy link
Collaborator

@pcw109550 pcw109550 commented Jun 12, 2024

Description

Remove op-bindings and use abigen(from geth) + justfile for updating go bindings.

Tests

Added new CI step rvgo-abigen to check whether contract is updated but binding is not. Check out 41b8fc7 for example.

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.25%. Comparing base (4058373) to head (c52299d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   70.46%   72.25%   +1.79%     
==========================================
  Files          19       16       -3     
  Lines        2810     2725      -85     
==========================================
- Hits         1980     1969      -11     
+ Misses        742      671      -71     
+ Partials       88       85       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pcw109550 pcw109550 force-pushed the tip/pcw109550/update-bindings branch from de43eef to de1d237 Compare June 12, 2024 20:42
@pcw109550 pcw109550 force-pushed the tip/pcw109550/update-bindings branch from 06c22b7 to 08936f2 Compare June 12, 2024 20:56
@pcw109550 pcw109550 force-pushed the tip/pcw109550/update-bindings branch from 41b8fc7 to d99f83f Compare June 12, 2024 21:30
@pcw109550 pcw109550 force-pushed the tip/pcw109550/update-bindings branch from 5fe0a7e to c52299d Compare June 12, 2024 21:36
@pcw109550 pcw109550 requested a review from ImTei June 12, 2024 21:38
@pcw109550 pcw109550 marked this pull request as ready for review June 12, 2024 21:38
Copy link
Collaborator

@ImTei ImTei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should consider migration makefile to justfile, anyway looks good!

@pcw109550 pcw109550 added this pull request to the merge queue Jun 12, 2024
Merged via the queue into master with commit 5a20396 Jun 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants