-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scripts: Stage 1.4 deployment #65
Merged
pcw109550
merged 9 commits into
master
from
tip/pcw109550/asterisc-deploy-no-devnet-no-critical-path
Jun 19, 2024
Merged
scripts: Stage 1.4 deployment #65
pcw109550
merged 9 commits into
master
from
tip/pcw109550/asterisc-deploy-no-devnet-no-critical-path
Jun 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #65 +/- ##
=======================================
Coverage 72.25% 72.25%
=======================================
Files 16 16
Lines 2725 2725
=======================================
Hits 1969 1969
Misses 671 671
Partials 85 85 ☔ View full report in Codecov by Sentry. |
pcw109550
force-pushed
the
tip/pcw109550/asterisc-deploy-no-devnet-no-critical-path
branch
from
June 17, 2024 19:58
034a86a
to
78caca4
Compare
clabby
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! One small change for the ASR deployment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added deployment script to deploy necessary contracts for stage 1.4, referring to
FPACOPS.sol
andDeploy.s.sol
from the monorepo. I chose not to use safe contracts to make the implementation more simple. All the new contract's ownership will be set to deployer, not the safe contract.Deploying below contract is necessary:
ProxyAdmin
,DisputeGameFactoryProxy
,AnchorStateRegistryProxy
DisputeGameFactory
,AnchorStateRegistry
,RISCV
We reuse existing contracts. They are already deployed:
PreimageOracle
for deployingRISCV
DelayedWETH
for creating initial Fault Dispute Game.After deployment, we
setImplementation
andsetInitBond
for asterisc by interacting with DGF.After local devnet deployment, I get below new contract addresses:
Tests
Manual testing done. Did the following:
Did not play the actual dispute games, but only initalized them. Will test manually using local devnet then sepolia.
To test the script locally,