Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary serialization of VMState and monorepo update to 117c9a427168 #82

Merged
merged 13 commits into from
Oct 15, 2024

Conversation

mininny
Copy link
Collaborator

@mininny mininny commented Oct 1, 2024

Description

Adds support for binary serialization of snapshots, while preserving compatibility with JSON snapshots. We infer the type of the snapshot by looking at the file type, and dynamically choose whether to use binary representation of json representation.

Mirror of cannon PR here: ethereum-optimism/optimism#11718. This PR uses cannon's serialize package.

Using binary snapshots are expected to improve the performance.

Tests

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 20.19231% with 83 lines in your changes missing coverage. Please review.

Project coverage is 62.05%. Comparing base (019d4b9) to head (6928d38).

Files with missing lines Patch % Lines
rvgo/fast/state.go 18.46% 27 Missing and 26 partials ⚠️
rvgo/cmd/witness.go 0.00% 14 Missing ⚠️
rvgo/fast/memory.go 42.85% 6 Missing and 6 partials ⚠️
rvgo/cmd/run.go 0.00% 3 Missing ⚠️
rvgo/cmd/load_elf.go 0.00% 1 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (019d4b9) and HEAD (6928d38). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (019d4b9) HEAD (6928d38)
2 1
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #82      +/-   ##
==========================================
- Coverage   71.03%   62.05%   -8.98%     
==========================================
  Files          16       26      +10     
  Lines        2772     3236     +464     
==========================================
+ Hits         1969     2008      +39     
- Misses        719     1112     +393     
- Partials       84      116      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rvgo/fast/state.go Outdated Show resolved Hide resolved
@mininny mininny force-pushed the feature/mininny/binary-serialization branch 12 times, most recently from 9aa7b3f to 105dde8 Compare October 6, 2024 21:28
@mininny mininny force-pushed the feature/mininny/binary-serialization branch from 105dde8 to e55251c Compare October 8, 2024 17:00
@mininny mininny force-pushed the feature/mininny/binary-serialization branch from 7ee61fe to 4f10841 Compare October 8, 2024 18:00
@mininny mininny changed the title Binary serialization of VMState Binary serialization of VMState and monorepo update to 117c9a427168 Oct 8, 2024
@mininny mininny requested a review from ajsutton October 8, 2024 23:11
@mininny mininny added this pull request to the merge queue Oct 15, 2024
Merged via the queue into master with commit e1a5b01 Oct 15, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants