-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binary serialization of VMState and monorepo update to 117c9a427168 #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #82 +/- ##
==========================================
- Coverage 71.03% 62.05% -8.98%
==========================================
Files 16 26 +10
Lines 2772 3236 +464
==========================================
+ Hits 1969 2008 +39
- Misses 719 1112 +393
- Partials 84 116 +32 ☔ View full report in Codecov by Sentry. |
ajsutton
reviewed
Oct 2, 2024
mininny
force-pushed
the
feature/mininny/binary-serialization
branch
12 times, most recently
from
October 6, 2024 21:28
9aa7b3f
to
105dde8
Compare
mininny
force-pushed
the
feature/mininny/binary-serialization
branch
from
October 8, 2024 17:00
105dde8
to
e55251c
Compare
mininny
force-pushed
the
feature/mininny/binary-serialization
branch
from
October 8, 2024 18:00
7ee61fe
to
4f10841
Compare
mininny
changed the title
Binary serialization of VMState
Binary serialization of VMState and monorepo update to 117c9a427168
Oct 8, 2024
ImTei
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for binary serialization of snapshots, while preserving compatibility with JSON snapshots. We infer the type of the snapshot by looking at the file type, and dynamically choose whether to use binary representation of json representation.
Mirror of cannon PR here: ethereum-optimism/optimism#11718. This PR uses cannon's
serialize
package.Using binary snapshots are expected to improve the performance.
Tests
Individual tests for VMState / Memory serialization/deserialization are added here: https://github.com/ethereum-optimism/asterisc/blob/feature/mininny/binary-serialization/rvgo/fast/state_test.go, https://github.com/ethereum-optimism/asterisc/blob/585e8ff7f3a763d36c64585f9fc52385875c5fde/rvgo/fast/memory_test.go
Existing tests, like prestate comparison which uses json representation are confirmed as passing.