Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validation script should use the OptimismMintableERC20 interface #916

Open
hamdiallam opened this issue Aug 27, 2024 · 2 comments
Open

Validation script should use the OptimismMintableERC20 interface #916

hamdiallam opened this issue Aug 27, 2024 · 2 comments
Labels
bug Something isn't working op

Comments

@hamdiallam
Copy link
Contributor

hamdiallam commented Aug 27, 2024 •
edited
Loading

Surfaced in #915

L2StandardERC20 imported here is an outdated interface. L2 tokens just implementing the IOptimismMintableERC20 interface should be compatible with the validation script without needing to implement the legacy methods as well.

This part just needs to be updated
@hamdiallam hamdiallam added the bug Something isn't working label Aug 27, 2024
@hamdiallam hamdiallam self-assigned this Aug 27, 2024
@raahulrathore raahulrathore mentioned this issue Aug 28, 2024
Merged
@nitaliano nitaliano mentioned this issue Oct 28, 2024
Open
@wbnns wbnns added the op label Dec 30, 2024
@hamdiallam hamdiallam removed their assignment Jan 6, 2025
@fainashalts
Copy link
Collaborator

Hi @hamdiallam I see this is a P0 - can you confirm if so?

@fainashalts
Copy link
Collaborator

Hi @hamdiallam just following up! Is this a P0 task?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working op
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@wbnns @fainashalts @hamdiallam