Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incompleteness balanche change reason #408

Open
kchojn opened this issue Oct 23, 2024 · 0 comments · May be fixed by #443 or #456
Open

incompleteness balanche change reason #408

kchojn opened this issue Oct 23, 2024 · 0 comments · May be fixed by #443 or #456

Comments

@kchojn
Copy link
Contributor

kchojn commented Oct 23, 2024

Due to the additional balance change reason that op-geth provides, the stringer should be re-generated - gen_balance_change_reason_stringer.go

System information

Geth version: geth version: 1.14.11
CL client & version: e.g. lighthouse/nimbus/prysm@v1.0.0: -
OS & Version: Windows/Linux/OSX: -
Commit hash : (if develop): -

Expected behaviour

tracing.BalanceChangeReason.String() for BalanceMint returns "BalanceMint"

Actual behaviour

tracing.BalanceChangeReason.String() for BalanceMint returns "BalanceChangeReason(200)"
@protolambda protolambda linked a pull request Dec 3, 2024 that will close this issue
Open
@spacexbt spacexbt linked a pull request Dec 30, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@kchojn