cmd/geth: add RollupEnableTxPoolAdmissionFlag to node flags #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In PR #122, the --rollup.enabletxpooladmission flag was added, but it is not listed in the node flags, making it unavailable for use. While it is correct to keep this flag disabled by default for non-sequencer nodes due to MEV vulnerabilities, it can be somewhat inconvenient when sending multiple transfer transactions at once, as the nonces do not increase accordingly. How about adding an option in this PR to allow users to enable it selectively?
Tests
Enabling the --rollup.enabletxpooladmission flag ensures that the nonce increments correctly.
Additional context
Metadata