forked from paradigmxyz/reth
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(isthmus): verify storage root in execution #19
Open
emhane
wants to merge
18
commits into
isthmus-devnet-0
Choose a base branch
from
emhane/exec-verif-storage-root
base: isthmus-devnet-0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+835
−1,196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
added
B-isthmus-devnet-0
Related to isthmus-devnet-0
A-consensus
Related to consensus engine
A-execution
Related to execution and EVM
labels
Jan 3, 2025
pending op-node upgrade https://github.com/ethereum-optimism/op-reth/actions/runs/12642532357 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-consensus
Related to consensus engine
A-execution
Related to execution and EVM
B-isthmus-devnet-0
Related to isthmus-devnet-0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4, #5
Supersedes #3
Partially upstreamed in paradigmxyz#13538
Moves isthmus storage root verification into execution, instead of after execution. This way storage root verification can happen for batch executed blocks in pipeline sync, as well as in live sync. Furthermore it requires less changes to reth's and op-reth's shared type system.