prank delegatecall bug demo

ethereum-optimism · Jan 4, 2025 · 64bb4b7 · 64bb4b7
1 parent 01fba5c
commit 64bb4b7
Showing 1 changed file with 11 additions and 2 deletions.
diff --git a/packages/contracts-bedrock/test/setup/ForkLive.s.sol b/packages/contracts-bedrock/test/setup/ForkLive.s.sol
@@ -1,6 +1,7 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.0;
 
+import { console } from "forge-std/console.sol";
 // Testing
 import { stdJson } from "forge-std/StdJson.sol";
 
@@ -132,17 +133,25 @@ contract ForkLive is Deployer {
         IProxyAdmin proxyAdmin = IProxyAdmin(EIP1967Helper.getAdmin(address(systemConfig)));
 
         address upgrader = proxyAdmin.owner();
+        vm.label(upgrader, "ProxyAdmin Owner");
 
         ISystemConfig[] memory systemConfigs = new ISystemConfig[](1);
         systemConfigs[0] = systemConfig;
         IProxyAdmin[] memory proxyAdmins = new IProxyAdmin[](1);
         proxyAdmins[0] = proxyAdmin;
 
         // TODO: Add support for this prank() call to forge-std
-        (bool success,) = address(vm).call(abi.encodeWithSignature("prank(address,bool)", upgrader, true));
+        console.log("delegatecall with prank");
+        (bool success,) = address(vm).call(abi.encodeWithSignature("prank(address,bool)", address(this), true));
         require(success, "ForkLive: Failed to prank");
 
-        (success,) = address(opcm).delegatecall(abi.encodeCall(OPContractsManager.upgrade, (systemConfigs, proxyAdmins)));
+        (success,) =
+            address(opcm).delegatecall(abi.encodeCall(OPContractsManager.upgrade, (systemConfigs, proxyAdmins)));
+        require(success, "ForkLive: Upgrade failed");
+
+        console.log("delegatecall without prank");
+        (success,) =
+            address(opcm).delegatecall(abi.encodeCall(OPContractsManager.upgrade, (systemConfigs, proxyAdmins)));
         require(success, "ForkLive: Upgrade failed");
     }