-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix labelling of addresses in Setup.sol #13391
Labels
Comments
maurelian
added
D-good-first-issue
Difficulty: A great task to get started
good first issue
labels
Dec 13, 2024
I'll try this one. Thank you. |
This was referenced Dec 14, 2024
Nice |
is the issue fixed? |
maurelian
added a commit
that referenced
this issue
Dec 20, 2024
maurelian
added a commit
that referenced
this issue
Dec 20, 2024
maurelian
added a commit
that referenced
this issue
Jan 2, 2025
maurelian
added a commit
that referenced
this issue
Jan 3, 2025
maurelian
added a commit
that referenced
this issue
Jan 4, 2025
This will be fixed by #13563. |
maurelian
added a commit
that referenced
this issue
Jan 6, 2025
maurelian
added a commit
that referenced
this issue
Jan 7, 2025
maurelian
added a commit
that referenced
this issue
Jan 8, 2025
github-merge-queue bot
pushed a commit
that referenced
this issue
Jan 8, 2025
…CM (#13563) * feat: Fix contract labels and make more explicit Fixes #13391 * fix: Initializable test * update gas-snapshot * feat: fix constructor tests * fix: Initializable test * feat: remove unused import * fix: DeployOwnership script * feat: cleanup * feat: Label contracts in save() function * feat: Add _removeSuffix * Address feedback * fix OptimismPortal2Impl name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The address labelling in this section of the code is incorrect.
Specifically:
The text was updated successfully, but these errors were encountered: