Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix labelling of addresses in Setup.sol #13391

Closed
maurelian opened this issue Dec 13, 2024 · 4 comments · Fixed by #13563
Closed

Fix labelling of addresses in Setup.sol #13391

maurelian opened this issue Dec 13, 2024 · 4 comments · Fixed by #13563
Labels
D-good-first-issue Difficulty: A great task to get started good first issue

Comments

@maurelian
Copy link
Contributor

The address labelling in this section of the code is incorrect.

Specifically:

  1. Proxy addresses are labelled twice, as both the proxy and the impl. The code should change as follows to correctly label the proxy and impl:
    optimismPortal = IOptimismPortal(deploy.mustGetAddress("OptimismPortalProxy"));
    
    ...
    
    - vm.label(address(optimismPortal), "OptimismPortal");
    + vm.label(address(optimismPortal), "OptimismPortalProxy");
    - vm.label(deploy.mustGetAddress("OptimismPortalProxy"), "OptimismPortalProxy");
    + vm.label(EIP1967Helper.getImplementation(address(optimismPortal)), "OptimismPortalImpl");
  2. Check for missing addresses, ie. the AnchorStateRegistry is not labelled at all.
@maurelian maurelian added D-good-first-issue Difficulty: A great task to get started good first issue labels Dec 13, 2024
@ChineseHamberger
Copy link

I'll try this one. Thank you.

@UnionSummer09
Copy link

Nice

@anushkasomani
Copy link

is the issue fixed?

@maurelian
Copy link
Contributor Author

This will be fixed by #13563.

github-merge-queue bot pushed a commit that referenced this issue Jan 8, 2025
…CM (#13563)

* feat: Fix contract labels and make more explicit

Fixes #13391

* fix: Initializable test

* update gas-snapshot

* feat: fix constructor tests

* fix: Initializable test

* feat: remove unused import

* fix: DeployOwnership script

* feat: cleanup

* feat: Label contracts in save() function

* feat: Add _removeSuffix

* Address feedback

* fix OptimismPortal2Impl name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D-good-first-issue Difficulty: A great task to get started good first issue
Projects
None yet
4 participants