Add Foundry tests for EAS.sol #13538

Red-Pandaz · 2024-12-27T17:54:41Z

Description

This PR adds EAS.t.sol, a comprehensive test suite for the EAS (Ethereum Attestation Service) contract implementation. The test suite verifies core EAS functionality including:

Contract construction and initialization
EIP-712 signature verification for attestations
Direct and delegated attestation flows
Multi-attestation handling
Revocation functionality
Error cases and edge conditions

Tests

The test suite includes:

Construction Tests
- Initial contract state verification
- Invalid schema registry handling
Signature Verification Tests
- Expired deadline handling
- Invalid signer detection
- Data tampering prevention
- Direct and delegated signature flows
- Proxy attestation verification
Attestation Tests
- Basic schema-based attestations
- Resolver integration
- Expiration time validation
- Schema-less attestations
- Delegated attestations
  - Single and multi-delegated flows
  - Signature verification
  - Deadline handling
- Multi-attestation scenarios
  - Batch processing
  - Multiple recipients
  - Error handling
Revocation Tests
- Direct revocation
- Delegated revocation
- Multi-revocation scenarios
- Irrevocable schema handling
- Off-chain revocation
- Invalid revocation attempts
Timestamping Tests
- Single and batch timestamping
- Timestamp duplication prevention
- Verification scenarios
- Unregistered timestamp handling

All tests use the Forge testing framework and include fuzz testing for enhanced coverage.

Changes to Supporting Files

Updated Setup.sol to include IEAS and ISchemaRegistry interfaces for proper test initialization and integration (SchemaRegistry.sol tests have been written and can be added in a future PR)

tynes · 2025-01-01T00:34:28Z

/ci authorize 3b8e02b

tynes · 2025-01-01T00:39:28Z

go run ./scripts/checks/unused-imports
❌  test/vendor/eas/EAS.t.sol: IERC1271
❌  test/vendor/eas/EAS.t.sol: Strings
❌  test/vendor/eas/EAS.t.sol: ECDSA
error: processing failed
exit status 1
error: Recipe `unused-imports-check-no-build` failed on line 233 with exit code 1

Try fixing this and pushing another commit

tynes · 2025-01-01T01:21:14Z

/ci authorize 7c8354b

tynes · 2025-01-01T02:10:14Z

Run just lint and commit the diff. Then run just gas-snapshot and commit the diff

tynes · 2025-01-01T22:53:53Z

/ci authorize b3e3c4a

tynes · 2025-01-02T22:13:01Z

/ci authorize 6d88f14

tynes · 2025-01-03T01:27:05Z

/ci authorize 9440c30

tynes · 2025-01-03T04:53:38Z

packages/contracts-bedrock/test/vendor/eas/EAS.t.sol

@@ -0,0 +1,3080 @@
+// SPDX-License-Identifier: MIT
+pragma solidity =0.8.15;


nit: nowhere else in the codebase does it do =0.8.15, this is semantically correct but also equivalent to just 0.8.15 which the rest of the codebase uses

tynes · 2025-01-03T04:54:14Z

packages/contracts-bedrock/test/vendor/eas/EAS.t.sol

+    }
+}
+
+// Mainnet Contract


nit: this comment isn't useful

tynes · 2025-01-03T04:55:54Z

packages/contracts-bedrock/test/vendor/eas/EAS.t.sol

+    error DeadlineExpired();
+
+    // Test State
+    ISchemaRegistry public registry;


registry looks unused. Can you make sure there aren't any unused variables here?

packages/contracts-bedrock/lib/forge-std

tynes · 2025-01-06T16:07:30Z

/ci authorize 444c106

tynes · 2025-01-14T04:40:06Z

Looks like this needs a rebase, its a small conflict

tynes · 2025-01-14T04:41:32Z

packages/contracts-bedrock/src/vendor/eas/IEAS_EIP1271.sol

@@ -0,0 +1,6 @@
+// SPDX-License-Identifier: MIT
+pragma solidity ^0.8.0;
+


Since this is only used in the test file, I think its fine to define in there, unless the linter requires this file to exist

The interface was moved into its own file to fix a CI testing failure. I can't recall the specific error but it was related to the Solidity version.

…tionWithSignatures, and testDetailedAttestationScenarios

…on tests

…tion_invalidLength_reverts and test_attestation_dataScenarios_succeeds

…ime_succeeds and test_attestation_delegated_succeeds

…_succeeds and test_cascadingRevocation_succeeds

…in_succeeds

…atedUnique_succeeds

Red-Pandaz requested a review from a team as a code owner December 27, 2024 17:54

Red-Pandaz requested a review from ajsutton December 27, 2024 17:54

tynes requested review from AmadiMichael and removed request for ajsutton January 1, 2025 00:38

tynes reviewed Jan 3, 2025

View reviewed changes

packages/contracts-bedrock/test/vendor/eas/EAS.t.sol

}

}

// Mainnet Contract

Copy link

Contributor

tynes Jan 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this comment isn't useful

tynes reviewed Jan 3, 2025

View reviewed changes

AmadiMichael reviewed Jan 3, 2025

View reviewed changes

packages/contracts-bedrock/lib/forge-std Outdated Show resolved Hide resolved

tynes reviewed Jan 14, 2025

View reviewed changes

Red-Pandaz added 12 commits January 13, 2025 23:17

add tests for SchemaRegistry

3079f9f

add EAS.t.sol

6b7238f

Fix and pass testAttestationExpirationScenarios

ece82dd

Fix and pass testMultiRevocationWithValue

625b43c

Fix and pass testMultiAttestationWithValue

a639642

Fix and pass testDeadlineScenarios

2966bc4

Fix and pass testAttestationExpirationScenarios, testDelegatedAttesta…

ad9dd5d

…tionWithSignatures, and testDetailedAttestationScenarios

Fix and pass testBatchProcessingLimits

0874df8

Fix and pass testCannotAttestWithExpiredTime

123b3aa

Fix and pass testConstructionScenarios, remove testConstructorRevers

2d7a198

Fix and pass testMultiAttestationDelegationRevert

d68bdd4

Standardize error selectors

d183d32

Red-Pandaz and others added 29 commits January 13, 2025 23:17

clean up comments and fix Delegated Revocation tests

a085d49

Clean up comments in SchemaRegistry

664b049

Complete fuzz testing for SchemaRegistry

01673f9

Add fuzz testing for EIP1271Verifier

e41c2a8

Fix AlreadyTimestamped error in testMultiStimestampRevert

c58d7e5

Add fuzz testing to SchemaResolver

f365b18

Touch up EAS comments

024bbb4

Make construction test up to date

8a8b76c

Fix comment format

d9bd231

Remove all non EAS tests

22ad1b0

Remove unused imports

fb01e29

fix: correct isAlphanumeric function logic

a667f22

test: update gas snapshot for L1StandardBridge finalization (+3 gas)

28ec490

test: split attestation expiration test and fix naming convention

43b5906

refactor(tests): standardize test naming and dedupe expired attestati…

bb7b8fa

…on tests

Move IEAS_EIP1271 to its own file and add _ to helper function names

febc773

Add underscore to remaining helper functions

97a3cba

fix(tests): relax fuzzing constraints for test_attestationMultiDelega…

c16a830

…tion_invalidLength_reverts and test_attestation_dataScenarios_succeeds

fix(tests): relax fuzzing constraints for test_attestation_delegatedT…

f5a4441

…ime_succeeds and test_attestation_delegated_succeeds

fix(tests): relax fuzzing constraints for test_attestation_multiValue…

649e3a5

…_succeeds and test_cascadingRevocation_succeeds

fix(tests): relax fuzzing constraints for test_revokation_multiOffcha…

3894662

…in_succeeds

fix(tests): relax fuzzing constraints for test_attestation_multiDeleg…

963af2f

…atedUnique_succeeds

Update lib/forge-std

f960a79

Attempt at solving AlreadyRevoked errors

2507b32

fix(tests): fix remaining test functions

d669d65

style: apply solidity formatting standards

ee034e6

style: standardize forge test naming conventions

4c1f6c8

style: remove redundant revocation test

e54d1a7

Set forge-std to v1.9.3

dd8fb10

Red-Pandaz force-pushed the eas-test-only branch from 444c106 to dd8fb10 Compare January 14, 2025 14:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Foundry tests for EAS.sol #13538

Add Foundry tests for EAS.sol #13538

Red-Pandaz commented Dec 27, 2024

tynes commented Jan 1, 2025

tynes commented Jan 1, 2025 •

edited

Loading

tynes commented Jan 1, 2025

tynes commented Jan 1, 2025

tynes commented Jan 1, 2025

tynes commented Jan 2, 2025

tynes commented Jan 3, 2025

tynes Jan 3, 2025

tynes Jan 3, 2025

tynes Jan 3, 2025

tynes commented Jan 6, 2025

tynes commented Jan 14, 2025

tynes Jan 14, 2025

Red-Pandaz Jan 14, 2025

		@@ -0,0 +1,3080 @@
		// SPDX-License-Identifier: MIT
		pragma solidity =0.8.15;

		@@ -0,0 +1,6 @@
		// SPDX-License-Identifier: MIT
		pragma solidity ^0.8.0;

Add Foundry tests for EAS.sol #13538

Are you sure you want to change the base?

Add Foundry tests for EAS.sol #13538

Conversation

Red-Pandaz commented Dec 27, 2024

tynes commented Jan 1, 2025

tynes commented Jan 1, 2025 • edited Loading

tynes commented Jan 1, 2025

tynes commented Jan 1, 2025

tynes commented Jan 1, 2025

tynes commented Jan 2, 2025

tynes commented Jan 3, 2025

tynes Jan 3, 2025

Choose a reason for hiding this comment

tynes Jan 3, 2025

Choose a reason for hiding this comment

tynes Jan 3, 2025

Choose a reason for hiding this comment

tynes commented Jan 6, 2025

tynes commented Jan 14, 2025

tynes Jan 14, 2025

Choose a reason for hiding this comment

Red-Pandaz Jan 14, 2025

Choose a reason for hiding this comment

tynes commented Jan 1, 2025 •

edited

Loading