Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] L1 nonce for consensus events (deposits + config updates) #13539

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mdehoog
Copy link
Contributor

@mdehoog mdehoog commented Dec 27, 2024

Description

Implementation of ethereum-optimism/specs#330 (comment), more details coming soon...

Tracker issue: #13543

Tests

Additional context

Metadata

@mdehoog mdehoog force-pushed the michael/deposit-queue branch 3 times, most recently from bb0c03c to 116598a Compare December 27, 2024 19:54
Copy link

codecov bot commented Dec 27, 2024

Codecov Report

Attention: Patch coverage is 58.25545% with 134 lines in your changes missing coverage. Please review.

Project coverage is 47.36%. Comparing base (d784a98) to head (0d86ad8).

Files with missing lines Patch % Lines
op-node/rollup/derive/l1_block_info.go 58.82% 18 Missing and 10 partials ⚠️
op-service/eth/types.go 0.00% 27 Missing ⚠️
op-node/rollup/derive/deposit_log.go 40.47% 25 Missing ⚠️
op-chain-ops/genesis/config.go 0.00% 11 Missing ⚠️
op-node/rollup/derive/system_config.go 25.00% 9 Missing ⚠️
op-node/rollup/derive/attributes.go 38.46% 5 Missing and 3 partials ⚠️
op-node/rollup/derive/payload_util.go 0.00% 6 Missing ⚠️
op-node/rollup/sequencing/sequencer.go 0.00% 3 Missing and 1 partial ⚠️
op-node/rollup/attributes/engine_consolidate.go 0.00% 3 Missing ⚠️
...node/rollup/derive/isthmus_upgrade_transactions.go 85.00% 2 Missing and 1 partial ⚠️
... and 6 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13539      +/-   ##
===========================================
- Coverage    47.49%   47.36%   -0.14%     
===========================================
  Files          945      948       +3     
  Lines        79019    79193     +174     
  Branches       761      762       +1     
===========================================
- Hits         37530    37509      -21     
- Misses       38648    38829     +181     
- Partials      2841     2855      +14     
Flag Coverage Δ
cannon-go-tests-32 62.27% <ø> (-1.98%) ⬇️
cannon-go-tests-64 57.35% <ø> (-1.62%) ⬇️
contracts-bedrock-tests 91.76% <89.55%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
op-chain-ops/interopgen/recipe.go 74.80% <100.00%> (+0.10%) ⬆️
op-node/rollup/derive/deposits.go 71.87% <100.00%> (+1.87%) ⬆️
op-program/client/l2/engineapi/l2_engine_api.go 33.69% <100.00%> (+0.18%) ⬆️
op-service/sources/types.go 58.63% <100.00%> (+0.21%) ⬆️
...contracts-bedrock/src/L1/OptimismPortalInterop.sol 100.00% <100.00%> (+33.33%) ⬆️
...contracts-bedrock/src/L1/OptimismPortalIsthmus.sol 100.00% <100.00%> (ø)
...s/contracts-bedrock/src/L1/SystemConfigInterop.sol 100.00% <100.00%> (+10.00%) ⬆️
...s/contracts-bedrock/src/L1/SystemConfigIsthmus.sol 100.00% <100.00%> (ø)
...ckages/contracts-bedrock/src/L2/L1BlockInterop.sol 100.00% <100.00%> (+5.40%) ⬆️
op-chain-ops/cmd/deposit-hash/main.go 0.00% <0.00%> (ø)
... and 15 more

... and 21 files with indirect coverage changes

@mdehoog mdehoog force-pushed the michael/deposit-queue branch 14 times, most recently from b299bc9 to b38eac2 Compare December 29, 2024 03:35
@mdehoog mdehoog changed the title [WIP] Deposit queue [WIP] L1 nonce for consensus events (deposits + config updates) Dec 29, 2024
@mdehoog mdehoog force-pushed the michael/deposit-queue branch 11 times, most recently from 48ac835 to 5486868 Compare December 31, 2024 01:06
@mdehoog mdehoog force-pushed the michael/deposit-queue branch 10 times, most recently from ef4a40d to 62ae75b Compare January 1, 2025 03:39
@mdehoog mdehoog force-pushed the michael/deposit-queue branch 2 times, most recently from 99f50cd to c083f5d Compare January 1, 2025 23:56
@mdehoog mdehoog force-pushed the michael/deposit-queue branch 2 times, most recently from 47f1cf4 to 7063cf8 Compare January 2, 2025 02:00
@@ -252,7 +252,7 @@ require (
rsc.io/tmplfunc v0.0.3 // indirect
)

replace github.com/ethereum/go-ethereum => github.com/ethereum-optimism/op-geth v1.101411.5-rc.1
replace github.com/ethereum/go-ethereum => github.com/mdehoog/op-geth v0.0.0-20250102015754-dc3e6fe74538
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will update once ethereum-optimism/op-geth#457 is merged

@mdehoog mdehoog force-pushed the michael/deposit-queue branch from fcdf93e to 0d86ad8 Compare January 6, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant