[Isthmus] Add missing Isthmus activation time updates #13549
+84
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #13549 +/- ##
===========================================
- Coverage 47.48% 47.35% -0.13%
===========================================
Files 945 945
Lines 79017 79024 +7
Branches 760 760
===========================================
- Hits 37519 37425 -94
- Misses 38656 38765 +109
+ Partials 2842 2834 -8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mdehoog
force-pushed
the
michael/isthmus-updates
branch
from
dcb376f to
ec0418f
Compare
mdehoog
changed the title
mdehoog
commented
Jan 2, 2025
| @@ -252,7 +252,7 @@ require ( | |||
| rsc.io/tmplfunc v0.0.3 // indirect | |||
| ) | |||
|
|
|||
| replace github.com/ethereum/go-ethereum => github.com/ethereum-optimism/op-geth v1.101411.5-rc.1 | |||
| replace github.com/ethereum/go-ethereum => github.com/ethereum-optimism/op-geth v1.101411.5-rc.1.0.20241219170731-928070c7fc09 | |||
There was a problem hiding this comment.
pulls in this fix: ethereum-optimism/op-geth@928070c, which is not part of a release yet
|
cc @vdamle |
|
@mdehoog I see I missed a few of the timestamp activation fields in #12847 , thanks for adding these! For the addition of withdrawalsRoot fields to the structs, i've got those changes in #12848 -- that PR will likely take longer to review, so I'm happy to rebase these changes assuming this one lands first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As I was implementing #13539, I came across a bunch of what appears to be missing Isthmus updates. This PR adds:
L2GenesisIsthmusTimeOffset/IsthmusTimesetsWithdrawalsRootengine API valueDeployConfig=> genesisSystemConfigconversion (there were two duplicate implementations).Tests
No new tests added. Adding the Isthmus activation before the Interop activation means the Isthmus code is now being tested by the interop tests (which is what showed up the missing
WithdrawalsRootsets).We may want to add
OP_E2E_USE_ISTHMUSto the E2E environmment?