Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OPCM is defined as proxied in Deploy.s.sol #13566

Closed
wants to merge 1 commit into from
Closed

Fix OPCM is defined as proxied in Deploy.s.sol #13566

wants to merge 1 commit into from

Conversation

Abuchtela
Copy link

Remove OPContractsManager from the deployment and chain assertions scripts.

  • Deploy.s.sol

    • Remove the OPContractsManager from the _impls function.
    • Remove the OPContractsManager from the deployImplementations function.
    • Remove the OPContractsManager from the deployOpChain function.
    • Remove the OPContractsManager from the ChainAssertions.checkOPContractsManager function.
    • Remove the OPContractsManager from the run function.

  • ChainAssertions.sol

    • Remove the ChainAssertions.checkOPContractsManager function.

@Abuchtela
Fix OPCM is defined as proxied in Deploy.s.sol
786f0b2 
Remove `OPContractsManager` from the deployment and chain assertions scripts.

* **Deploy.s.sol**
  - Remove the `OPContractsManager` from the `_impls` function.
  - Remove the `OPContractsManager` from the `deployImplementations` function.
  - Remove the `OPContractsManager` from the `deployOpChain` function.
  - Remove the `OPContractsManager` from the `ChainAssertions.checkOPContractsManager` function.
  - Remove the `OPContractsManager` from the `run` function.

* **ChainAssertions.sol**
  - Remove the `ChainAssertions.checkOPContractsManager` function.
@Abuchtela Abuchtela requested a review from a team as a code owner January 2, 2025 23:32
@Abuchtela Abuchtela requested a review from blmalone January 2, 2025 23:32
maurelian
maurelian reviewed Jan 7, 2025
View reviewed changes
Copy link
Contributor

@maurelian maurelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We definitely don't want to do this. Although not proxied, we still want to deploy the OPCM via deployImplementations.

@maurelian maurelian closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurelian maurelian maurelian left review comments

@blmalone blmalone Awaiting requested review from blmalone blmalone is a code owner automatically assigned from ethereum-optimism/contract-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Abuchtela @maurelian