Implement ISemver in all on-chain contracts #13567
Open
+66
−1,651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ethereum-optimism#13508 Add `ISemver` implementation to `RISCV.sol` and semgrep rule for `ISemver` compliance. * **RISCV.sol** - Add `ISemver` to the list of inherited contracts. - Add the `version()` function from `ISemver`. - Set the `version` constant to "1.2.0-rc.1". * **.semgrep/rules/sol-rules.yaml** - Add a semgrep rule to ensure all on-chain contracts implement `ISemver`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/ethereum-optimism/optimism/issues/13508?shareId=XXXX-XXXX-XXXX-XXXX).
tynes
reviewed
Jan 6, 2025
| } | ||
| } | ||
| } | ||
| 1: // SPDX-License-Identifier: MIT |
There was a problem hiding this comment.
This looks like a copy paste, there are prefix line numbers in the source
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13508
Add
ISemverimplementation toRISCV.soland semgrep rule forISemvercompliance.RISCV.sol
ISemverto the list of inherited contracts.version()function fromISemver.versionconstant to "1.2.0-rc.1"..semgrep/rules/sol-rules.yaml
ISemver.For more details, open the Copilot Workspace session.