Add deployImplementations to ForkLive flow #13573
Open
+71
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 3, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
maurelian
force-pushed
the
opcm-up/deploy-names-match-opcm-names
branch
from
462d3ab to
8e643a4
Compare
maurelian
force-pushed
the
opcm-up/add-deployImpls-to-fork-live
branch
4 times, most recently
from
157879e to
f3b007b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## opcm-up/deploy-names-match-opcm-names #13573 +/- ##
======================================================================
Coverage 88.99% 88.99%
======================================================================
Files 109 109
Lines 4588 4588
Branches 761 761
======================================================================
Hits 4083 4083
Misses 464 464
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more. |
maurelian
requested review from
clabby,
smartcontracts and
mds1
and removed request for
a team
maurelian
force-pushed
the
opcm-up/deploy-names-match-opcm-names
branch
from
cbc6606 to
050944f
Compare
maurelian
force-pushed
the
opcm-up/add-deployImpls-to-fork-live
branch
from
c023b16 to
7d1a662
Compare
maurelian
force-pushed
the
opcm-up/deploy-names-match-opcm-names
branch
from
050944f to
3e7d2cd
Compare
maurelian
force-pushed
the
opcm-up/add-deployImpls-to-fork-live
branch
from
7d1a662 to
d6e9629
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added support for deploying the
developversions of contract implementations alongside implementations from the forked network.What changed?
Deploy.deployImplementationsto:save("SystemConfigImpl_NextVersion")).Deployon the forked network to deploy new implementations.