OPCM Upgrade implementations only #13574
Open
+226
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 3, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
maurelian
force-pushed
the
opcm-up/add-deployImpls-to-fork-live
branch
from
fd4304d to
c0742df
Compare
maurelian
force-pushed
the
opcm-up/update-impls-only
branch
from
d3b8d13 to
ddda6a8
Compare
maurelian
force-pushed
the
opcm-up/add-deployImpls-to-fork-live
branch
from
c0742df to
e54effb
Compare
maurelian
force-pushed
the
opcm-up/update-impls-only
branch
from
ddda6a8 to
2c1ff57
Compare
maurelian
force-pushed
the
opcm-up/add-deployImpls-to-fork-live
branch
from
e54effb to
157879e
Compare
maurelian
force-pushed
the
opcm-up/update-impls-only
branch
from
2c1ff57 to
f249a03
Compare
maurelian
force-pushed
the
opcm-up/add-deployImpls-to-fork-live
branch
from
157879e to
f3b007b
Compare
maurelian
force-pushed
the
opcm-up/update-impls-only
branch
2 times, most recently
from
68a5ec9 to
a0a1d04
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## opcm-up/add-deployImpls-to-fork-live #13574 +/- ##
========================================================================
- Coverage 88.99% 88.74% -0.25%
========================================================================
Files 109 109
Lines 4588 4602 +14
Branches 761 761
========================================================================
+ Hits 4083 4084 +1
- Misses 464 477 +13
Partials 41 41
Flags with carried forward coverage won't be shown. Click here to find out more.
|
maurelian
force-pushed
the
opcm-up/update-impls-only
branch
from
1713b2b to
aa75952
Compare
maurelian
force-pushed
the
opcm-up/add-deployImpls-to-fork-live
branch
from
c023b16 to
7d1a662
Compare
maurelian
force-pushed
the
opcm-up/update-impls-only
branch
from
aa75952 to
3bd493c
Compare
maurelian
changed the title
maurelian
force-pushed
the
opcm-up/add-deployImpls-to-fork-live
branch
from
7d1a662 to
d6e9629
Compare
maurelian
force-pushed
the
opcm-up/update-impls-only
branch
from
6ba1d89 to
392f064
Compare
maurelian
force-pushed
the
opcm-up/update-impls-only
branch
from
392f064 to
26bdb34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of a stack leading up to performing the full Isthmus upgrade via the
OPCM.upgrade()function.In order to keep the diff small, this PR currently only updates the implementations of the contracts, meaning it cannot be expected to pass all upgrade tests as
initialize()/upgrade()is not called on contracts which receive new state variables.The next PR will aim to have all checks passing on the upgrade path.