Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kurtosis-devnet): adjust build definitions #13579

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

sigma
Copy link
Contributor

@sigma sigma commented Jan 3, 2025

Description

  • fix the op-challenger image build, as currently
    ops/docker/op-stack-go/Dockerfile defaults to a non-existing tag.

  • make it easier to point to an alternate kurtosis package (like a
    local for for example)

- fix the op-challenger image build, as currently
  ops/docker/op-stack-go/Dockerfile defaults to a non-existing tag.

- make it easier to point to an alternate kurtosis package (like a
local for for example)
Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.07%. Comparing base (dedf345) to head (390f400).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13579      +/-   ##
===========================================
- Coverage    47.37%   43.07%   -4.31%     
===========================================
  Files          945      779     -166     
  Lines        79019    69659    -9360     
  Branches       761        0     -761     
===========================================
- Hits         37433    30003    -7430     
+ Misses       38751    37080    -1671     
+ Partials      2835     2576     -259     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 175 files with indirect coverage changes

@sigma sigma marked this pull request as ready for review January 4, 2025 00:08
@sigma sigma requested a review from a team as a code owner January 4, 2025 00:08
@sigma sigma requested a review from scharissis January 4, 2025 00:08
@mslipper mslipper added this pull request to the merge queue Jan 6, 2025
Merged via the queue into develop with commit d32c41e Jan 6, 2025
43 checks passed
@mslipper mslipper deleted the sigma/kurtosis-devnet-pq-16 branch January 6, 2025 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants