Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kurtosis-devnet): split SDK-based logic into separate pkgs #13581

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

sigma
Copy link
Contributor

@sigma sigma commented Jan 4, 2025

Description

This is a code cleanup change.

This moves all the code built on top of Kurtosis SDK into separate
packages for better clarity.

Tests

Additional context

Metadata

This is a code cleanup change.

This moves all the code built on top of Kurtosis SDK into separate
packages for better clarity.
Copy link

codecov bot commented Jan 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.05%. Comparing base (7e76fc6) to head (dd321ad).
Report is 8 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #13581      +/-   ##
===========================================
- Coverage    47.49%   43.05%   -4.44%     
===========================================
  Files          945      779     -166     
  Lines        79019    69659    -9360     
  Branches       761        0     -761     
===========================================
- Hits         37528    29995    -7533     
+ Misses       38645    37087    -1558     
+ Partials      2846     2577     -269     
Flag Coverage Δ
cannon-go-tests-32 ?
cannon-go-tests-64 ?
contracts-bedrock-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 173 files with indirect coverage changes

@sigma sigma marked this pull request as ready for review January 4, 2025 06:21
@sigma sigma requested a review from a team as a code owner January 4, 2025 06:22
@sigma sigma requested a review from Inphi January 4, 2025 06:22
@sigma sigma added this pull request to the merge queue Jan 6, 2025
Merged via the queue into develop with commit cb75596 Jan 6, 2025
43 checks passed
@sigma sigma deleted the sigma/kurtosis-devnet-pq-18 branch January 6, 2025 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants