Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannon: Add mtcannon64 state versioning #13582

Conversation

mbaxter
Copy link
Contributor

@mbaxter mbaxter commented Jan 4, 2025

Description

Add state versioning for 64-bit MTCannon.

Tests

Unit tests

Updated unit tests.

Dockerfile

Manually tested dockerfile.

Built with:

docker build \
  -f ops/docker/op-stack-go/Dockerfile \
  --target cannon-target \
  --build-arg GIT_COMMIT=$(git rev-parse HEAD) \
  --build-arg GIT_DATE=$(git show -s --format='%ct') \
  --build-arg CANNON_VERSION=v0.0.0 \
  -t cannon-test-image .

Tested cannon multithreaded64 (version 3) with to make sure the witnessHash is generated as expected:

docker run --rm -it \
  -v ~/Downloads:/app/files:ro \
  cannon-test-image \
  cannon witness --input /app/files/0x03b7eaa4e3cbce90381921a4b48008f4769871d64f93d113fcadca08ecee503b.bin.gz
{
  "witnessHash": "0x03b7eaa4e3cbce90381921a4b48008f4769871d64f93d113fcadca08ecee503b",
  "witness": "0x0216b5113df5cdeb88456085ece51c5d2521b5a9f8660c6ca5093f6dc2834f700000000000000000000000000000000000000000000000000000000000000000000000000000000000001000000000000000000000000000000000000000000000000000000000000000000000000000000000ffffffffffffffff00f3696961711850c078769d4c7874f7a08f7175b1d8407878bf2eb9ef3ae430fdad3228b676f7d3cd4284a5443f17f1962b36e491b30a40b2405849e597ba5fb50000000000000001",
  "step": 0,
  "exited": false,
  "exitCode": 0
}

Validated additional state hashes with this script.

@mbaxter mbaxter requested a review from Inphi January 4, 2025 00:37
Copy link
Contributor

@Inphi Inphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mbaxter
Copy link
Contributor Author

mbaxter commented Jan 6, 2025

/ci authorize 197b20d

@mbaxter mbaxter marked this pull request as ready for review January 6, 2025 15:12
@mbaxter mbaxter requested review from a team as code owners January 6, 2025 15:12
@mbaxter mbaxter added this pull request to the merge queue Jan 6, 2025
Merged via the queue into ethereum-optimism:develop with commit a81c70c Jan 6, 2025
44 checks passed
@mbaxter mbaxter deleted the cannon/add-mtcannon-state-versioning branch January 6, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants