You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Task sep/026 introduced a reusable verification framework to reduce the work of writing, maintaining and reviewing individual verification scripts. Part of this framework is a small VerificationBase contract
contractVerificationBase {
address[] public allowedStorageAccess;
address[] public codeExceptions;
function addAllowedStorageAccess(addressaddr) internal {
allowedStorageAccess.push(addr);
}
function addCodeException(addressaddr) internal {
codeExceptions.push(addr);
}
}
It provides two dynamic arrays in storage to allow for verification modules to add their respective allowed storage accesses and code exceptions. This allows for a more modular management of these addresses than the static overrides of getAllowedStorageAccess and getCodeException.
I propose that we just merge this contract into JsonTxBuilderBase, and set its getters to just return those arrays, instead of setting default virtual getters that revert. The getters can still be virtual so that they can be overridden, which mostly provides backwards compatibility for the old pattern where individual tasks had to override the getters. I don't see a security risk from providing a default way to add accesses and exceptions via the add... functions. After all, adding these only makes checks more permissive.
The text was updated successfully, but these errors were encountered:
Task sep/026 introduced a reusable verification framework to reduce the work of writing, maintaining and reviewing individual verification scripts. Part of this framework is a small
VerificationBase
contractIt provides two dynamic arrays in storage to allow for verification modules to add their respective allowed storage accesses and code exceptions. This allows for a more modular management of these addresses than the static overrides of
getAllowedStorageAccess
andgetCodeException
.I propose that we just merge this contract into
JsonTxBuilderBase
, and set its getters to just return those arrays, instead of setting default virtual getters that revert. The getters can still bevirtual
so that they can be overridden, which mostly provides backwards compatibility for the old pattern where individual tasks had to override the getters. I don't see a security risk from providing a default way to add accesses and exceptions via theadd...
functions. After all, adding these only makes checks more permissive.The text was updated successfully, but these errors were encountered: