Skip to content

Commit

Permalink
Avoid generating empty transactions in tests
Browse files Browse the repository at this point in the history
Transactions cannot be empty, they always have at least 1 byte.
Random tests should produce valid CL data by default.
There are still individual tests for invalid transactions.
  • Loading branch information
etan-status committed Aug 14, 2024
1 parent 13ac373 commit 99bf3c1
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions tests/core/pyspec/eth2spec/test/helpers/execution_payload.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def compute_trie_root_from_indexed_data(data):
t = HexaryTrie(db={})
for i, obj in enumerate(data):
k = encode(i, big_endian_int)
t.set(k, obj)
t.set(k, obj) # Implicitly skipped if `obj == b''` (invalid RLP)
return t.root_hash


Expand Down Expand Up @@ -359,4 +359,4 @@ def build_state_with_execution_payload_header(spec, state, execution_payload_hea


def get_random_tx(rng):
return get_random_bytes_list(rng, rng.randint(0, 1000))
return get_random_bytes_list(rng, rng.randint(1, 1000))

0 comments on commit 99bf3c1

Please sign in to comment.