Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace links to eth2.0-specs with consensus-specs #3934

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

jtraglia
Copy link
Member

This PR replaces language referring to Ethereum 2.0 with the current terminology.

@jtraglia jtraglia added the general:proofread spelling, grammar, accuracy label Sep 20, 2024
Copy link
Member

@ralexstokes ralexstokes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

im a little hesitant to touch the source code of the deposit contract files, on the basis of keeping the source the same for a very critical contract to the ethereum protocol

you are only touching the comments so its likely ok, but I could imagine consumers relying on some fingerprint of this file that would then change after this PR

@jtraglia
Copy link
Member Author

im a little hesitant to touch the source code of the deposit contract files, on the basis of keeping the source the same for a very critical contract to the ethereum protocol

Yes, that's a valid concern. I also think it should be fine, but I can revert those changes if we want.

@jtraglia
Copy link
Member Author

I just realized that "eth2spec" is all over the place & wouldn't be easy to replace. We can save that for another day.

@jtraglia jtraglia changed the title Replace references to Ethereum 2.0 Replace references to eth2.0-specs with consensus-specs Sep 24, 2024
@jtraglia jtraglia changed the title Replace references to eth2.0-specs with consensus-specs Replace links to eth2.0-specs with consensus-specs Sep 24, 2024
@hwwhww hwwhww merged commit 72e9a31 into ethereum:dev Sep 26, 2024
26 checks passed
@jtraglia jtraglia deleted the replace-eth2.0 branch September 26, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
general:proofread spelling, grammar, accuracy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants