Add a negative test for full exit has partial withdrawal #3946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terencechain
force-pushed
the
full-exit-has-partial-withdrawal-test
branch
3 times, most recently
from
d7742f0
to
7d3c744
Compare
terencechain
force-pushed
the
full-exit-has-partial-withdrawal-test
branch
from
7d3c744
to
8385726
Compare
jtraglia
reviewed
Sep 30, 2024
tests/core/pyspec/eth2spec/test/electra/block_processing/test_process_withdrawal_request.py
Outdated
Show resolved
Hide resolved
mkalinin
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
process_withdrawal_request, the full exit amount, this PR adds a test case to ensure only full exit can go through and there's no pending partial withdrawal in the state.Note to the reviewer: feel free to push any changes to my PR as needed