Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix validator fields in get_validator_from_deposit #3978

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

jtraglia
Copy link
Member

When comparing the spec to Teku, I noticed that (1) effective_balance was in the wrong spot and (2) slashed wasn't being set. There's no bug here, just fixing for correctness & to make reviewing easier.

class Validator(Container):
pubkey: BLSPubkey
withdrawal_credentials: Bytes32 # Commitment to pubkey for withdrawals
effective_balance: Gwei # Balance at stake
slashed: boolean
# Status epochs
activation_eligibility_epoch: Epoch # When criteria for activation were met
activation_epoch: Epoch
exit_epoch: Epoch
withdrawable_epoch: Epoch # When validator can withdraw funds

@Scutua

This comment has been minimized.

@jtraglia jtraglia merged commit da3b23a into ethereum:dev Oct 14, 2024
26 checks passed
@jtraglia jtraglia deleted the fix-new-validator-order branch October 14, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants