Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add proof Equal methods #458

Merged
merged 5 commits into from
Oct 25, 2024
Merged

add proof Equal methods #458

merged 5 commits into from
Oct 25, 2024

Conversation

jsign
Copy link
Collaborator

@jsign jsign commented Oct 21, 2024

This PR adds .Equal methods to proof fields so clients can compare re-generated proofs against block proofs.

This is required for gballet/go-ethereum#515

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
proof_json.go Outdated Show resolved Hide resolved
@jsign jsign marked this pull request as ready for review October 22, 2024 11:57
@jsign jsign requested a review from gballet October 22, 2024 11:58
Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
Copy link
Member

@gballet gballet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It's a bit annoying that we'll have to do it again when we switch to type 3 encoding, but we'll manage I guess.

Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
@gballet gballet merged commit a80b12b into master Oct 25, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants