Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds handling for content in beacon network #428

Merged
merged 12 commits into from
Aug 15, 2023
Merged

Conversation

acolytec3
Copy link
Collaborator

@acolytec3 acolytec3 commented Aug 1, 2023

Adds storing and retrieving of Beacon network content from local storage as well as a partial implementation of the SENDFINDCONTENT flow. This currently only handles the case where the content is delivered via uTP stream.

@acolytec3 acolytec3 marked this pull request as ready for review August 15, 2023 16:41
Copy link
Collaborator

@ScottyPoi ScottyPoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM!

I think it's worth Typescript engineering something around the content types as we start to add more networks, but that's more about style than function.

:+1 to merge this and then work on setting up new tests

@acolytec3 acolytec3 merged commit 99fb319 into master Aug 15, 2023
2 checks passed
@acolytec3
Copy link
Collaborator Author

Overall, LGTM!

I think it's worth Typescript engineering something around the content types as we start to add more networks, but that's more about style than function.

:+1 to merge this and then work on setting up new tests

Agreed. Probably some sort of nested enum if that exists but haven't gotten that far yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants